[cleanup] Introduce PropertyFilter

src/objects-inl.h

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 //
 // Review notes:
 //
 // - The use of macros in these inline functions may seem superfluous
 // but it is absolutely needed to make sure gcc generates optimal
 // code. gcc is not happy when attempting to inline too deep.
 //
@@ skipping 262 matching lines @@
   if (first->IsNumber()) {
     DCHECK_LE(0, first->Number());
     uint32_t expected = static_cast<uint32_t>(first->Number());
     uint32_t index;
     return Name::cast(second)->AsArrayIndex(&index) && index == expected;
   }
   return Name::cast(first)->Equals(Name::cast(second));
 }
 
 
-bool Object::FilterKey(PropertyAttributes filter) {
-  if ((filter & SYMBOLIC) && IsSymbol()) {
-    return true;
+bool Object::FilterKey(PropertyFilter filter) {
+  if (IsSymbol()) {
+    if (filter & SKIP_SYMBOLS) return true;
+    if (Symbol::cast(this)->is_private()) return true;
   }
-
-  if ((filter & PRIVATE_SYMBOL) && IsSymbol() &&
-      Symbol::cast(this)->is_private()) {
-    return true;
-  }
-
-  if ((filter & STRING) && !IsSymbol()) {
-    return true;
-  }
+  if ((filter & SKIP_STRINGS) && !IsSymbol()) return true;
 
   return false;
 }
 
 
 Handle<Object> Object::NewStorageFor(Isolate* isolate,
                                      Handle<Object> object,
                                      Representation representation) {
   if (representation.IsSmi() && object->IsUninitialized()) {
     return handle(Smi::FromInt(0), isolate);
@@ skipping 7550 matching lines @@
 #undef WRITE_INT64_FIELD
 #undef READ_BYTE_FIELD
 #undef WRITE_BYTE_FIELD
 #undef NOBARRIER_READ_BYTE_FIELD
 #undef NOBARRIER_WRITE_BYTE_FIELD
 
 }  // namespace internal
 }  // namespace v8
 
 #endif  // V8_OBJECTS_INL_H_