Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(356)

Issue 1492653004: [cleanup] Introduce PropertyFilter (Closed)

Created:
5 years ago by Jakob Kummerow
Modified:
5 years ago
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan, Yang
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[cleanup] Introduce PropertyFilter Split out of PropertyAttributes, and used for all filtering purposes. Also moved PropertyAttributes into the v8::internal:: namespace. No change in behavior intended. Committed: https://crrev.com/4a246c1fff4ecee5aa0ed799bea249d8b4845367 Cr-Commit-Position: refs/heads/master@{#32525}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : windows ♥ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+197 lines, -198 lines) Patch
M src/api.cc View 14 chunks +25 lines, -19 lines 0 comments Download
M src/builtins.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M src/debug/debug-scopes.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M src/elements.h View 2 chunks +4 lines, -4 lines 0 comments Download
M src/elements.cc View 10 chunks +13 lines, -17 lines 0 comments Download
M src/heap/mark-compact.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/js/macros.py View 1 chunk +1 line, -2 lines 0 comments Download
M src/json-stringifier.h View 1 chunk +1 line, -1 line 0 comments Download
M src/key-accumulator.h View 3 chunks +3 lines, -5 lines 0 comments Download
M src/key-accumulator.cc View 3 chunks +12 lines, -10 lines 0 comments Download
M src/objects.h View 8 chunks +15 lines, -23 lines 0 comments Download
M src/objects.cc View 1 2 33 chunks +55 lines, -69 lines 0 comments Download
M src/objects-inl.h View 1 chunk +5 lines, -12 lines 0 comments Download
M src/property-details.h View 2 chunks +24 lines, -12 lines 0 comments Download
M src/runtime/runtime-array.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/runtime/runtime-object.cc View 5 chunks +22 lines, -9 lines 0 comments Download
M test/cctest/test-alloc.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-api.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M test/cctest/test-debug.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 16 (7 generated)
Jakob Kummerow
You likey? You'll probably want to begin by looking at property-details.h. The other changes are ...
5 years ago (2015-12-02 14:17:48 UTC) #2
Toon Verwaest
lgtm
5 years ago (2015-12-02 14:55:42 UTC) #3
Jakob Kummerow
Hannes, can you please look at src/heap/?
5 years ago (2015-12-02 15:00:41 UTC) #5
Hannes Payer (out of office)
heap lgtm
5 years ago (2015-12-02 15:45:06 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1492653004/10020 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1492653004/10020
5 years ago (2015-12-02 15:45:34 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: v8_win_compile_dbg on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_win_compile_dbg/builds/10470)
5 years ago (2015-12-02 15:55:46 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1492653004/30001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1492653004/30001
5 years ago (2015-12-02 15:59:29 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:30001)
5 years ago (2015-12-02 16:30:13 UTC) #14
commit-bot: I haz the power
5 years ago (2015-12-02 16:30:33 UTC) #16
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/4a246c1fff4ecee5aa0ed799bea249d8b4845367
Cr-Commit-Position: refs/heads/master@{#32525}

Powered by Google App Engine
This is Rietveld 408576698