Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(413)

Issue 1492653002: Use the same clock for the profiler samples and timeline events. (Closed)

Created:
5 years ago by rmacnak
Modified:
5 years ago
Reviewers:
Ivan Posva
CC:
reviews_dartlang.org, vm-dev_dartlang.org, Cutch
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Use the same clock for the profiler samples and timeline events. Preparation for overlaying samples in the timeline. BUG= R=iposva@google.com Committed: https://github.com/dart-lang/sdk/commit/56239b14761f992d1c75084922423042dbc1e52d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M runtime/vm/object.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/profiler.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (3 generated)
rmacnak
5 years ago (2015-12-01 23:17:46 UTC) #2
Ivan Posva
LGTM -ip
5 years ago (2015-12-02 00:24:05 UTC) #3
rmacnak
5 years ago (2015-12-02 17:37:27 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
56239b14761f992d1c75084922423042dbc1e52d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698