Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3992)

Unified Diff: blimp/net/connection_handler.h

Issue 1492643003: [Blimp Net] Add EngineAuthHandler. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: blimp/net/connection_handler.h
diff --git a/blimp/net/connection_handler.h b/blimp/net/connection_handler.h
index b9d37f6199163030cd2fff0de551bda0a49eab72..afce887942c8af0f12ad45db3b71ccf3d5bdfe05 100644
--- a/blimp/net/connection_handler.h
+++ b/blimp/net/connection_handler.h
@@ -14,6 +14,9 @@ class ConnectionHandler {
public:
virtual ~ConnectionHandler() {}
+ // The receiving object is responsible for synchronously attaching its
+ // necessary delegates and observers to |connection| during the call to
+ // HandleConnection.
Wez 2015/12/04 01:35:38 I'm not keen on this - it means that all Connectio
haibinlu 2015/12/04 02:50:40 I do not like this either. It is the internal impl
virtual void HandleConnection(scoped_ptr<BlimpConnection> connection) = 0;
};

Powered by Google App Engine
This is Rietveld 408576698