blimp/common/proto/protocol_control.proto - Issue 1492643003: [Blimp Net] Add EngineAuthHandler.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: blimp/common/proto/protocol_control.proto

Issue 1492643003: [Blimp Net] Add EngineAuthHandler. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addresses Kevin's comments. Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: blimp/common/proto/protocol_control.proto

diff --git a/blimp/common/proto/size.proto b/blimp/common/proto/protocol_control.proto

similarity index 51%

copy from blimp/common/proto/size.proto

copy to blimp/common/proto/protocol_control.proto

index f6ba801495df51dbe000a44b4369861105d1ba3d..a5b2018655b1f430dd50169d52a5bc55ed991d57 100644

--- a/blimp/common/proto/size.proto

+++ b/blimp/common/proto/protocol_control.proto

@@ -8,10 +8,9 @@ option optimize_for = LITE_RUNTIME;

package blimp;

-// Contains display information that represents resize events coming from the

-// client device.

-message SizeMessage {

- optional uint64 width = 1;

- optional uint64 height = 2;

+// Contains Client->Engine information to establish a authenticated connection.

Kevin M 2015/12/03 23:12:05 ISTM that "protocol control" will be bidirectional

haibinlu 2015/12/03 23:42:21 Done.

+message ProtocolControlMessage {

+ optional string client_token = 1;

+ optional int32 protocol_version = 2;

+ // TODO(haibinlu): add checkpoints.

}