blimp/net/connection_handler.h - Issue 1492643003: [Blimp Net] Add EngineAuthHandler.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: blimp/net/connection_handler.h

Issue 1492643003: [Blimp Net] Add EngineAuthHandler. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: blimp/net/connection_handler.h

diff --git a/blimp/net/connection_handler.h b/blimp/net/connection_handler.h

index b9d37f6199163030cd2fff0de551bda0a49eab72..9be781e0a622326c479e29c176cc11f05d2a9f1e 100644

--- a/blimp/net/connection_handler.h

+++ b/blimp/net/connection_handler.h

@@ -14,6 +14,8 @@ class ConnectionHandler {

public:

virtual ~ConnectionHandler() {}

+ // Implementation must attach incoming message processor and error observer

Kevin M 2015/12/03 19:11:36 That seems like an impl detail. How about "The r

haibinlu 2015/12/03 22:28:35 Done.

+ // synchronously.

virtual void HandleConnection(scoped_ptr<BlimpConnection> connection) = 0;

};