blimp/common/proto/protocol_control.proto - Issue 1492643003: [Blimp Net] Add EngineAuthHandler.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: blimp/common/proto/protocol_control.proto

Issue 1492643003: [Blimp Net] Add EngineAuthHandler. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addresses Kevin's comments. Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 // Copyright 2015 The Chromium Authors. All rights reserved.	1 // Copyright 2015 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 syntax = "proto2";	5 syntax = "proto2";

6	6

7 option optimize_for = LITE_RUNTIME;	7 option optimize_for = LITE_RUNTIME;

8	8

9 package blimp;	9 package blimp;

10	10

11 // Contains display information that represents resize events coming from the	11 // Contains Client->Engine information to establish a authenticated connection.
	Kevin M 2015/12/03 23:12:05 ISTM that "protocol control" will be bidirectional ISTM that "protocol control" will be bidirectional and used for all protocol-related messaging, not just authentication. haibinlu 2015/12/03 23:42:21 Done. Show quoted text On 2015/12/03 23:12:05, Kevin M wrote: > ISTM that "protocol control" will be bidirectional and used for all > protocol-related messaging, not just authentication. Done.
12 // client device.	12 message ProtocolControlMessage {

13 message SizeMessage {	13 optional string client_token = 1;

14 optional uint64 width = 1;	14 optional int32 protocol_version = 2;

15 optional uint64 height = 2;	15 // TODO(haibinlu): add checkpoints.

16 }	16 }

17

OLD	NEW