Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Side by Side Diff: blimp/common/create_blimp_message.h

Issue 1492643003: [Blimp Net] Add EngineAuthHandler. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addresses comments and adds unit tests Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef BLIMP_COMMON_CREATE_BLIMP_MESSAGE_H_ 5 #ifndef BLIMP_COMMON_CREATE_BLIMP_MESSAGE_H_
6 #define BLIMP_COMMON_CREATE_BLIMP_MESSAGE_H_ 6 #define BLIMP_COMMON_CREATE_BLIMP_MESSAGE_H_
7 7
8 #include "base/memory/scoped_ptr.h" 8 #include "base/memory/scoped_ptr.h"
9 #include "blimp/common/blimp_common_export.h" 9 #include "blimp/common/blimp_common_export.h"
10 10
11 namespace blimp { 11 namespace blimp {
12 12
13 class BlimpMessage; 13 class BlimpMessage;
14 class CompositorMessage; 14 class CompositorMessage;
15 class InputMessage; 15 class InputMessage;
16 class RenderWidgetMessage; 16 class RenderWidgetMessage;
17 class StartConnectionMessage;
17 18
18 // Suite of helper methods to simplify the repetitive task of creating 19 // Suite of helper methods to simplify the repetitive task of creating
19 // new BlimpMessages, initializing them, and extracting type-specific 20 // new BlimpMessages, initializing them, and extracting type-specific
20 // inner messages. 21 // inner messages.
21 // 22 //
22 // 23 //
23 // Every specialization of CreateBlimpMessage returns an initialized 24 // Every specialization of CreateBlimpMessage returns an initialized
24 // BlimpMessage object. In addition, a pointer to the type-specific inner 25 // BlimpMessage object. In addition, a pointer to the type-specific inner
25 // message is returned via the initial double-pointer parameter. 26 // message is returned via the initial double-pointer parameter.
26 // 27 //
27 // Additional initialization arguments may be taken depending on the 28 // Additional initialization arguments may be taken depending on the
28 // message type. 29 // message type.
29 30
30 BLIMP_COMMON_EXPORT scoped_ptr<BlimpMessage> CreateBlimpMessage( 31 BLIMP_COMMON_EXPORT scoped_ptr<BlimpMessage> CreateBlimpMessage(
31 CompositorMessage** compositor_message, 32 CompositorMessage** compositor_message,
32 int target_tab_id); 33 int target_tab_id);
33 34
34 BLIMP_COMMON_EXPORT scoped_ptr<BlimpMessage> CreateBlimpMessage( 35 BLIMP_COMMON_EXPORT scoped_ptr<BlimpMessage> CreateBlimpMessage(
35 InputMessage** input_message); 36 InputMessage** input_message);
36 37
37 BLIMP_COMMON_EXPORT scoped_ptr<BlimpMessage> CreateBlimpMessage( 38 BLIMP_COMMON_EXPORT scoped_ptr<BlimpMessage> CreateBlimpMessage(
38 RenderWidgetMessage** render_widget_message, 39 RenderWidgetMessage** render_widget_message,
39 int target_tab_id); 40 int target_tab_id);
40 41
42 BLIMP_COMMON_EXPORT scoped_ptr<BlimpMessage> CreateBlimpMessage(
43 StartConnectionMessage** start_connection_message);
Wez 2015/12/08 00:31:41 Presumably we want to allow the caller to pass in
haibinlu 2015/12/08 01:54:50 Update new method name. Shall we use separate CL f
44
41 } // namespace blimp 45 } // namespace blimp
42 46
43 #endif // BLIMP_COMMON_CREATE_BLIMP_MESSAGE_H_ 47 #endif // BLIMP_COMMON_CREATE_BLIMP_MESSAGE_H_
OLDNEW
« no previous file with comments | « no previous file | blimp/common/create_blimp_message.cc » ('j') | blimp/common/proto/protocol_control.proto » ('J')

Powered by Google App Engine
This is Rietveld 408576698