blimp/common/proto/start_connection.proto - Issue 1492643003: [Blimp Net] Add EngineAuthHandler.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: blimp/common/proto/start_connection.proto

Issue 1492643003: [Blimp Net] Add EngineAuthHandler. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 // Copyright 2015 The Chromium Authors. All rights reserved.	1 // Copyright 2015 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 syntax = "proto2";	5 syntax = "proto2";

6	6

7 option optimize_for = LITE_RUNTIME;	7 option optimize_for = LITE_RUNTIME;

8	8

9 package blimp;	9 package blimp;

10	10

11 // Contains display information that represents resize events coming from the	11 // Contains Client->Engine information to establish a authenticated connection.

12 // client device.	12 message StartConnectionMessage {

13 message SizeMessage {	13 optional string auth_token = 1;
	maniscalco 2015/12/02 17:09:35 Elsewhere we've called this client_token. I sugge Elsewhere we've called this client_token. I suggest using that name here for consistency. haibinlu 2015/12/03 01:53:15 Done. Show quoted text On 2015/12/02 17:09:35, maniscalco wrote: > Elsewhere we've called this client_token. I suggest using that name here for > consistency. Done.
14 optional uint64 width = 1;	14 optional int32 protocol_version = 2;
	maniscalco 2015/12/02 17:09:35 Elsewhere this is defined as a string. Elsewhere this is defined as a string. haibinlu 2015/12/03 01:53:22 use int per offline discussion. Show quoted text On 2015/12/02 17:09:35, maniscalco wrote: > Elsewhere this is defined as a string. use int per offline discussion.
15 optional uint64 height = 2;	15 // TODO(haibinlu): add checkpoints.

16 }	16 }

17

OLD	NEW

« blimp/common/proto/blimp_message.proto ('K') | « blimp/common/proto/blimp_message.proto ('k') | blimp/net/BUILD.gn » ('j') | blimp/net/engine_auth_handler.h » ('J')