Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(318)

Issue 1492633004: Ensure that text with leading, trailing and interspersed tabs pasted into the textfield (Closed)

Created:
5 years ago by ananta
Modified:
5 years ago
Reviewers:
oshima
CC:
chromium-reviews, tfarina, James Su, shuchen+watch_chromium.org, yusukes+watch_chromium.org, nona+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Ensure that text with leading, trailing, interspersed tabs and spaces pasted into the textfield is sanitized correctly. We use the base::CollapseWhitespace helper function to achieve the desired results. BUG=500575 TEST=Covered by views unittest TextfieldModelTest.Clipboard_WhiteSpaceStringTest Committed: https://crrev.com/9836b46ff3617c72a1a0d58634e305868928dc12 Cr-Commit-Position: refs/heads/master@{#362782}

Patch Set 1 #

Patch Set 2 : Fixed the TextfieldModelTest.Clipboard test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+121 lines, -9 lines) Patch
M ui/views/controls/textfield/textfield_model.cc View 2 chunks +11 lines, -4 lines 0 comments Download
M ui/views/controls/textfield/textfield_model_unittest.cc View 1 2 chunks +110 lines, -5 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
ananta
5 years ago (2015-12-02 02:34:49 UTC) #2
oshima
lgtm
5 years ago (2015-12-02 16:24:31 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1492633004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1492633004/20001
5 years ago (2015-12-02 20:03:36 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years ago (2015-12-02 20:11:48 UTC) #10
commit-bot: I haz the power
5 years ago (2015-12-02 20:12:55 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/9836b46ff3617c72a1a0d58634e305868928dc12
Cr-Commit-Position: refs/heads/master@{#362782}

Powered by Google App Engine
This is Rietveld 408576698