Issue 149263002: Refactor QuicConnection to use explicit notification for getting onto

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 149263002: Refactor QuicConnection to use explicit notification for getting onto (Closed)

Created:
6 years, 10 months ago by ramant (doing other things)

Modified:
6 years, 10 months ago

Reviewers:
Ryan Hamilton

CC:
chromium-reviews, cbentzel+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Refactor QuicConnection to use explicit notification for getting onto the write blocked list. Remove the PacketWriter interface from QuicDispatcher. Merge internal change: 60103466 Fix build. Build got broken by a race between presubmit tests and me editing the file that was in the process of being submitted. :( Merge internal change: 60104577 R=rch@chromium.org

Patch Set 1 #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+101 lines, -120 lines)			Patch
M	net/quic/quic_connection.h	View	4 chunks	+19 lines, -21 lines	0 comments	Download
M	net/quic/quic_connection.cc	View	4 chunks	+23 lines, -11 lines	0 comments	Download
M	net/quic/quic_connection_test.cc	View	21 chunks	+27 lines, -25 lines	0 comments	Download
M	net/quic/test_tools/quic_test_utils.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	net/tools/quic/quic_client.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	net/tools/quic/quic_dispatcher.h	View	5 chunks	+9 lines, -18 lines	0 comments	Download
M	net/tools/quic/quic_dispatcher.cc	View	4 chunks	+20 lines, -43 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages