Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1492623002: EDK: Add functions for converting between strings and numbers. (Closed)

Created:
5 years ago by viettrungluu
Modified:
5 years ago
Reviewers:
vardhan
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

EDK: Add functions for converting between strings and numbers. (And convert "stuff".) R=vardhan@google.com Committed: https://chromium.googlesource.com/external/mojo/+/3d67098d1b819d3ea93dc554a750d6b838c4de01

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+530 lines, -3 lines) Patch
M mojo/edk/embedder/platform_channel_pair.cc View 3 chunks +5 lines, -3 lines 0 comments Download
M mojo/edk/util/BUILD.gn View 2 chunks +3 lines, -0 lines 0 comments Download
A mojo/edk/util/string_number_conversions.h View 1 chunk +46 lines, -0 lines 1 comment Download
A mojo/edk/util/string_number_conversions.cc View 1 chunk +158 lines, -0 lines 0 comments Download
A mojo/edk/util/string_number_conversions_unittest.cc View 1 chunk +318 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
viettrungluu
5 years ago (2015-12-01 22:49:55 UTC) #1
vardhan
https://codereview.chromium.org/1492623002/diff/1/mojo/edk/util/string_number_conversions.h File mojo/edk/util/string_number_conversions.h (right): https://codereview.chromium.org/1492623002/diff/1/mojo/edk/util/string_number_conversions.h#newcode20 mojo/edk/util/string_number_conversions.h:20: std::string NumberToString(NumberType number); is locale the only reason you ...
5 years ago (2015-12-02 00:07:42 UTC) #2
viettrungluu
On 2015/12/02 00:07:42, vardhan wrote: > https://codereview.chromium.org/1492623002/diff/1/mojo/edk/util/string_number_conversions.h > File mojo/edk/util/string_number_conversions.h (right): > > https://codereview.chromium.org/1492623002/diff/1/mojo/edk/util/string_number_conversions.h#newcode20 > ...
5 years ago (2015-12-02 01:10:56 UTC) #3
vardhan
lgtm
5 years ago (2015-12-02 01:12:22 UTC) #4
viettrungluu
5 years ago (2015-12-02 01:34:40 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
3d67098d1b819d3ea93dc554a750d6b838c4de01 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698