components/cronet/android/api/src/org/chromium/net/UrlResponseInfo.java - Issue 1492583002: Add HttpUrlConnection backed implementation of CronetEngine.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/cronet/android/api/src/org/chromium/net/UrlResponseInfo.java

Issue 1492583002: Add HttpUrlConnection backed implementation of CronetEngine. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Update tests and header ordering. Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/cronet/android/api/src/org/chromium/net/JavaUrlRequest.java ('K') | « components/cronet/android/api/src/org/chromium/net/Preconditions.java ('k') | components/cronet/android/java/src/org/chromium/net/CronetUrlRequest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/cronet/android/api/src/org/chromium/net/UrlResponseInfo.java

diff --git a/components/cronet/android/api/src/org/chromium/net/UrlResponseInfo.java b/components/cronet/android/api/src/org/chromium/net/UrlResponseInfo.java

index b8f407e22ffa217a9565c99ad4c80c07e1fb3513..f9461d95dee42463d78bb622bb62b7d44673ba15 100644

--- a/components/cronet/android/api/src/org/chromium/net/UrlResponseInfo.java

+++ b/components/cronet/android/api/src/org/chromium/net/UrlResponseInfo.java

@@ -61,8 +61,7 @@ public final class UrlResponseInfo {

if (mHeadersMap != null) {

return mHeadersMap;

}

- Map<String, List<String>> map =

- new TreeMap<String, List<String>>(String.CASE_INSENSITIVE_ORDER);

+ Map<String, List<String>> map = new TreeMap<>(String.CASE_INSENSITIVE_ORDER);

for (Map.Entry<String, String> entry : mAllHeadersList) {

List<String> values = new ArrayList<String>();

if (map.containsKey(entry.getKey())) {

@@ -205,10 +204,12 @@ public final class UrlResponseInfo {

@Override

public String toString() {

- return String.format(Locale.ROOT, "UrlResponseInfo[%s]: urlChain = %s, "

+ return String.format(Locale.ROOT, "UrlResponseInfo@[%s][%s]: urlChain = %s, "

+ "httpStatus = %d %s, headers = %s, wasCached = %b, "

+ "negotiatedProtocol = %s, proxyServer= %s, receivedBytesCount = %d",

- getUrl(), getUrlChain().toString(), getHttpStatusCode(), getHttpStatusText(),

+ // Prevent asserting on the contents of this string

+ Integer.toHexString(System.identityHashCode(this)), getUrl(),

+ getUrlChain().toString(), getHttpStatusCode(), getHttpStatusText(),

getAllHeadersAsList().toString(), wasCached(), getNegotiatedProtocol(),

getProxyServer(), getReceivedBytesCount());

}