Chromium Code Reviews| Index: components/cronet/android/api/src/org/chromium/net/CronetEngine.java |
| diff --git a/components/cronet/android/api/src/org/chromium/net/CronetEngine.java b/components/cronet/android/api/src/org/chromium/net/CronetEngine.java |
| index 5047ab6e23f289342e02621113f98ffaaf7afa9d..a24137100a5ceda817ae7ed4a63ac70fc4f047f3 100644 |
| --- a/components/cronet/android/api/src/org/chromium/net/CronetEngine.java |
| +++ b/components/cronet/android/api/src/org/chromium/net/CronetEngine.java |
| @@ -13,6 +13,7 @@ import org.json.JSONException; |
| import org.json.JSONObject; |
| import java.io.File; |
| +import java.io.IOException; |
| import java.lang.annotation.Retention; |
| import java.lang.annotation.RetentionPolicy; |
| import java.lang.reflect.Constructor; |
| @@ -594,7 +595,7 @@ public abstract class CronetEngine { |
| * @param url URL of resource to connect to. |
| * @return an {@link java.net.HttpURLConnection} instance implemented by this CronetEngine. |
| */ |
| - public abstract URLConnection openConnection(URL url); |
| + public abstract URLConnection openConnection(URL url) throws IOException; |
| /** |
| * Establishes a new connection to the resource specified by the {@link URL} {@code url} |
| @@ -611,7 +612,8 @@ public abstract class CronetEngine { |
| * javadocs are built with nodeprecated="yes". |
| * TODO(pauljensen): Expose once implemented, http://crbug.com/418111 |
| */ |
| - @SuppressWarnings("DepAnn") public abstract URLConnection openConnection(URL url, Proxy proxy); |
| + @SuppressWarnings("DepAnn") |
| + public abstract URLConnection openConnection(URL url, Proxy proxy) throws IOException; |
| /** |
| * Creates a {@link URLStreamHandlerFactory} to handle HTTP and HTTPS |
| @@ -666,7 +668,7 @@ public abstract class CronetEngine { |
| if (cronetEngine == null) { |
| // TODO(mef): Fallback to stub implementation. Once stub |
| // implementation is available merge with createCronetFactory. |
|
pauljensen
2015/12/08 19:49:52
Could you update this comment? At least the "Fall
Charles
2015/12/11 16:45:39
Done.
|
| - cronetEngine = createCronetEngine(builder); |
| + cronetEngine = new JavaCronetEngine(builder.getUserAgent()); |
| } |
| Log.i(TAG, "Using network stack: " + cronetEngine.getVersionString()); |
| return cronetEngine; |