components/cronet/android/test/javatests/src/org/chromium/net/GetStatusTest.java - Issue 1492583002: Add HttpUrlConnection backed implementation of CronetEngine.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/cronet/android/test/javatests/src/org/chromium/net/GetStatusTest.java

Issue 1492583002: Add HttpUrlConnection backed implementation of CronetEngine. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed comments Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/cronet/android/test/javatests/src/org/chromium/net/CronetUploadTest.java ('K') | « components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlTest.java ('k') | components/cronet/android/test/javatests/src/org/chromium/net/HttpUrlRequestFactoryTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/cronet/android/test/javatests/src/org/chromium/net/GetStatusTest.java

diff --git a/components/cronet/android/test/javatests/src/org/chromium/net/GetStatusTest.java b/components/cronet/android/test/javatests/src/org/chromium/net/GetStatusTest.java

index bbd5507e3815ad92e944f64311ad15318f4bc74c..c57a175ab00c9eaaadf05ed23933ee79330c2b34 100644

--- a/components/cronet/android/test/javatests/src/org/chromium/net/GetStatusTest.java

+++ b/components/cronet/android/test/javatests/src/org/chromium/net/GetStatusTest.java

@@ -73,8 +73,9 @@ public class GetStatusTest extends CronetTestBase {

urlRequest.getStatus(statusListener1);

statusListener1.waitUntilOnStatusCalled();

assertTrue(statusListener1.mOnStatusCalled);

- assertTrue(statusListener1.mStatus >= Status.IDLE);

- assertTrue(statusListener1.mStatus <= Status.READING_RESPONSE);

+ assertTrue("Status is :" + statusListener1.mStatus, statusListener1.mStatus >= Status.IDLE);

+ assertTrue("Status is :" + statusListener1.mStatus,

+ statusListener1.mStatus <= Status.READING_RESPONSE);

callback.waitForNextStep();

assertEquals(ResponseStep.ON_RESPONSE_STARTED, callback.mResponseStep);