Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(729)

Unified Diff: components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlRequestContextTest.java

Issue 1492583002: Add HttpUrlConnection backed implementation of CronetEngine. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase on HEAD Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlRequestContextTest.java
diff --git a/components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlRequestContextTest.java b/components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlRequestContextTest.java
index 32c28aaf7964964a144a4bfd90e0dfda0f5938ac..304b0d6314fd508e79ba9e014dabf25fc4c5615b 100644
--- a/components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlRequestContextTest.java
+++ b/components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlRequestContextTest.java
@@ -125,6 +125,7 @@ public class CronetUrlRequestContextTest extends CronetTestBase {
@SmallTest
@Feature({"Cronet"})
+ @OnlyRunNativeCronet
pauljensen 2015/12/21 20:27:58 why is this test disabled? please add a comment
Charles 2015/12/21 23:36:26 Done.
pauljensen 2015/12/29 16:35:53 We really need a test that the user-agent is set p
Charles 2016/01/06 19:17:51 Done.
public void testConfigUserAgent() throws Exception {
String userAgentName = "User-Agent";
String userAgentValue = "User-Agent-Value";
@@ -145,6 +146,7 @@ public class CronetUrlRequestContextTest extends CronetTestBase {
@SmallTest
@Feature({"Cronet"})
+ @OnlyRunNativeCronet
// TODO(xunjieli): Remove annotation after crbug.com/539519 is fixed.
@SuppressWarnings("deprecation")
public void testDataReductionProxyEnabled() throws Exception {
@@ -429,6 +431,7 @@ public class CronetUrlRequestContextTest extends CronetTestBase {
@SmallTest
@Feature({"Cronet"})
+ @OnlyRunNativeCronet
public void testNetLog() throws Exception {
Context context = getContext();
File directory = new File(PathUtils.getDataDirectory(context));
@@ -531,6 +534,7 @@ public class CronetUrlRequestContextTest extends CronetTestBase {
@SmallTest
@Feature({"Cronet"})
+ @OnlyRunNativeCronet
public void testNetLogWithBytes() throws Exception {
Context context = getContext();
File directory = new File(PathUtils.getDataDirectory(context));
@@ -601,6 +605,7 @@ public class CronetUrlRequestContextTest extends CronetTestBase {
@SmallTest
@Feature({"Cronet"})
+ @OnlyRunNativeCronet
public void testEnableHttpCacheDisabled() throws Exception {
enableCache(CronetEngine.Builder.HTTP_CACHE_DISABLED);
String url = NativeTestServer.getFileURL("/cacheable.txt");
@@ -633,6 +638,7 @@ public class CronetUrlRequestContextTest extends CronetTestBase {
@SmallTest
@Feature({"Cronet"})
+ @OnlyRunNativeCronet
public void testEnableHttpCacheDiskNoHttp() throws Exception {
enableCache(CronetEngine.Builder.HTTP_CACHE_DISABLED);
String url = NativeTestServer.getFileURL("/cacheable.txt");

Powered by Google App Engine
This is Rietveld 408576698