Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Unified Diff: components/cronet/android/api/src/org/chromium/net/UrlResponseInfo.java

Issue 1492583002: Add HttpUrlConnection backed implementation of CronetEngine. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase on HEAD Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/cronet/android/api/src/org/chromium/net/UrlResponseInfo.java
diff --git a/components/cronet/android/api/src/org/chromium/net/UrlResponseInfo.java b/components/cronet/android/api/src/org/chromium/net/UrlResponseInfo.java
index b8f407e22ffa217a9565c99ad4c80c07e1fb3513..f9461d95dee42463d78bb622bb62b7d44673ba15 100644
--- a/components/cronet/android/api/src/org/chromium/net/UrlResponseInfo.java
+++ b/components/cronet/android/api/src/org/chromium/net/UrlResponseInfo.java
@@ -61,8 +61,7 @@ public final class UrlResponseInfo {
if (mHeadersMap != null) {
return mHeadersMap;
}
- Map<String, List<String>> map =
- new TreeMap<String, List<String>>(String.CASE_INSENSITIVE_ORDER);
+ Map<String, List<String>> map = new TreeMap<>(String.CASE_INSENSITIVE_ORDER);
for (Map.Entry<String, String> entry : mAllHeadersList) {
List<String> values = new ArrayList<String>();
if (map.containsKey(entry.getKey())) {
@@ -205,10 +204,12 @@ public final class UrlResponseInfo {
@Override
public String toString() {
- return String.format(Locale.ROOT, "UrlResponseInfo[%s]: urlChain = %s, "
+ return String.format(Locale.ROOT, "UrlResponseInfo@[%s][%s]: urlChain = %s, "
+ "httpStatus = %d %s, headers = %s, wasCached = %b, "
+ "negotiatedProtocol = %s, proxyServer= %s, receivedBytesCount = %d",
- getUrl(), getUrlChain().toString(), getHttpStatusCode(), getHttpStatusText(),
+ // Prevent asserting on the contents of this string
pauljensen 2015/12/21 20:27:58 I don't understand this comment. How does adding
Charles 2015/12/21 23:36:25 This is a common pattern in java - including the i
pauljensen 2015/12/29 16:35:53 Acknowledged.
+ Integer.toHexString(System.identityHashCode(this)), getUrl(),
+ getUrlChain().toString(), getHttpStatusCode(), getHttpStatusText(),
getAllHeadersAsList().toString(), wasCached(), getNegotiatedProtocol(),
getProxyServer(), getReceivedBytesCount());
}

Powered by Google App Engine
This is Rietveld 408576698