Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(242)

Issue 1492563002: Introduce mash/shell (Closed)

Created:
5 years ago by Ben Goodger (Google)
Modified:
5 years ago
Reviewers:
sky
CC:
chromium-reviews, kalyank, sadrul
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Introduce mash/shell . restarts the services that it starts if they die . moves mock_sysui -> mash/system_ui. may as well build it into the real thing. TBD: shutdown, restart loops, etc. Also looks like sadrul's code to clean up windows doesn't work for sysui. R=sky@chromium.org http://crbug.com/563733 Committed: https://crrev.com/5a4099e1d40ab1863bedf2e18d233e99cbde333f Cr-Commit-Position: refs/heads/master@{#362561}

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Patch Set 4 : . #

Total comments: 1

Patch Set 5 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+186 lines, -222 lines) Patch
M mash/example/BUILD.gn View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M mash/example/main/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M mash/example/main/main_application_delegate.cc View 1 chunk +1 line, -2 lines 0 comments Download
M mash/example/mock_sysui/BUILD.gn View 1 2 1 chunk +0 lines, -34 lines 0 comments Download
D mash/example/mock_sysui/main.cc View 1 2 1 chunk +0 lines, -12 lines 0 comments Download
D mash/example/mock_sysui/mock_sysui.h View 1 2 1 chunk +0 lines, -35 lines 0 comments Download
M mash/example/mock_sysui/mock_sysui.cc View 1 2 1 chunk +0 lines, -110 lines 0 comments Download
A mash/shell/BUILD.gn View 1 2 1 chunk +30 lines, -0 lines 0 comments Download
A mash/shell/main.cc View 1 chunk +12 lines, -0 lines 0 comments Download
A mash/shell/shell_application_delegate.h View 1 1 chunk +50 lines, -0 lines 0 comments Download
A mash/shell/shell_application_delegate.cc View 1 2 3 4 1 chunk +54 lines, -0 lines 0 comments Download
A + mash/system_ui/BUILD.gn View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
A + mash/system_ui/main.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
A + mash/system_ui/system_ui.h View 1 2 3 chunks +13 lines, -7 lines 0 comments Download
A + mash/system_ui/system_ui.cc View 1 2 4 chunks +12 lines, -6 lines 0 comments Download
M mash/wm/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M mash/wm/background_layout.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M mash/wm/background_layout.cc View 1 1 chunk +3 lines, -3 lines 0 comments Download
M mash/wm/shelf_layout.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M mash/wm/shelf_layout.cc View 1 1 chunk +3 lines, -3 lines 0 comments Download
M mash/wm/window_manager_apptest.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
Ben Goodger (Google)
5 years ago (2015-12-01 22:30:08 UTC) #2
sky
LGTM as long as you make sure to global search/replace mash_wm with desktop_wm. https://codereview.chromium.org/1492563002/diff/60001/mash/shell/shell_application_delegate.h File ...
5 years ago (2015-12-01 22:40:09 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1492563002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1492563002/80001
5 years ago (2015-12-01 22:46:37 UTC) #6
commit-bot: I haz the power
Committed patchset #5 (id:80001)
5 years ago (2015-12-02 00:12:27 UTC) #8
commit-bot: I haz the power
5 years ago (2015-12-02 00:15:15 UTC) #10
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/5a4099e1d40ab1863bedf2e18d233e99cbde333f
Cr-Commit-Position: refs/heads/master@{#362561}

Powered by Google App Engine
This is Rietveld 408576698