Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1492533003:
Change Skia-related proto enums to uppercase (Closed)
DescriptionChange Skia-related proto enums to uppercase
This CL changes Skia-related enums defined in .proto-files to use
uppercase, and also remove the Enum_ prefix.
This is done as a follow-up to another CL dealing with serialization:
https://codereview.chromium.org/1490513005/
The argument for doing this is to keep a consistent style,
and Chromium's style guide uses ALL_UPPERCASE for enum values.
BUG=561210
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
Committed: https://crrev.com/ac756a7db81feb6a0c29821a598dd679c6a837d3
Cr-Commit-Position: refs/heads/master@{#391118}
Patch Set 1 #Patch Set 2 : Rebased #Patch Set 3 : Blindly trying to fix win compile issue #Patch Set 4 : Rebased #Patch Set 5 : git merge origin/master #Patch Set 6 : Change DIFFERENCE to DIFFERENCE_ since DIFFERENCE is already defined in winuser.h for Windows platf… #Patch Set 7 : Fix another DIFFERENCE #
Messages
Total messages: 42 (22 generated)
Description was changed from ========== Change Skia-related proto enums to uppercase This CL changes Skia-related enums defined in .proto-files to use uppercase, and also remove the Enum_ prefix. This is done as a follow-up to another CL dealing with serialization: https://codereview.chromium.org/1490513005/ The argument for doing this is to keep a consistent style, and the reviewer of the above mentioned CL preferred this style. BUG=561210 ========== to ========== Change Skia-related proto enums to uppercase This CL changes Skia-related enums defined in .proto-files to use uppercase, and also remove the Enum_ prefix. This is done as a follow-up to another CL dealing with serialization: https://codereview.chromium.org/1490513005/ The argument for doing this is to keep a consistent style, and the reviewer of the above mentioned CL preferred this style. BUG=561210 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel ==========
nyquist@chromium.org changed reviewers: + dtrainor@chromium.org, vmpstr@chromium.org
vmpstr, dtrainor: PTAL
To defend my choice: it's because that's the Chromium style for naming enums :P lgtm.
Description was changed from ========== Change Skia-related proto enums to uppercase This CL changes Skia-related enums defined in .proto-files to use uppercase, and also remove the Enum_ prefix. This is done as a follow-up to another CL dealing with serialization: https://codereview.chromium.org/1490513005/ The argument for doing this is to keep a consistent style, and the reviewer of the above mentioned CL preferred this style. BUG=561210 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel ========== to ========== Change Skia-related proto enums to uppercase This CL changes Skia-related enums defined in .proto-files to use uppercase, and also remove the Enum_ prefix. This is done as a follow-up to another CL dealing with serialization: https://codereview.chromium.org/1490513005/ The argument for doing this is to keep a consistent style, and Chromium's style guide uses ALL_UPPERCASE for enum names. BUG=561210 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel ==========
Description was changed from ========== Change Skia-related proto enums to uppercase This CL changes Skia-related enums defined in .proto-files to use uppercase, and also remove the Enum_ prefix. This is done as a follow-up to another CL dealing with serialization: https://codereview.chromium.org/1490513005/ The argument for doing this is to keep a consistent style, and Chromium's style guide uses ALL_UPPERCASE for enum names. BUG=561210 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel ========== to ========== Change Skia-related proto enums to uppercase This CL changes Skia-related enums defined in .proto-files to use uppercase, and also remove the Enum_ prefix. This is done as a follow-up to another CL dealing with serialization: https://codereview.chromium.org/1490513005/ The argument for doing this is to keep a consistent style, and Chromium's style guide uses ALL_UPPERCASE for enum values. BUG=561210 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel ==========
On 2015/12/01 22:40:12, vmpstr wrote: > To defend my choice: it's because that's the Chromium style for naming enums :P > > lgtm. updated CL description to reflect this.
lgtm!
The CQ bit was checked by nyquist@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1492533003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1492533003/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win8_chromium_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_ng/...)
The CQ bit was checked by nyquist@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from dtrainor@chromium.org, vmpstr@chromium.org Link to the patchset: https://codereview.chromium.org/1492533003/#ps40001 (title: "Blindly trying to fix win compile issue")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1492533003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1492533003/40001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by nyquist@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1492533003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1492533003/60001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by nyquist@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1492533003/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1492533003/80001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_compile_dbg_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...) win_clang on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)
The CQ bit was checked by nyquist@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1492533003/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1492533003/100001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_clang on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)
The CQ bit was checked by nyquist@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1492533003/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1492533003/100001
The CQ bit was checked by nyquist@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1492533003/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1492533003/120001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by nyquist@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from dtrainor@chromium.org, vmpstr@chromium.org Link to the patchset: https://codereview.chromium.org/1492533003/#ps120001 (title: "Fix another DIFFERENCE")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1492533003/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1492533003/120001
Message was sent while issue was closed.
Description was changed from ========== Change Skia-related proto enums to uppercase This CL changes Skia-related enums defined in .proto-files to use uppercase, and also remove the Enum_ prefix. This is done as a follow-up to another CL dealing with serialization: https://codereview.chromium.org/1490513005/ The argument for doing this is to keep a consistent style, and Chromium's style guide uses ALL_UPPERCASE for enum values. BUG=561210 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel ========== to ========== Change Skia-related proto enums to uppercase This CL changes Skia-related enums defined in .proto-files to use uppercase, and also remove the Enum_ prefix. This is done as a follow-up to another CL dealing with serialization: https://codereview.chromium.org/1490513005/ The argument for doing this is to keep a consistent style, and Chromium's style guide uses ALL_UPPERCASE for enum values. BUG=561210 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel ==========
Message was sent while issue was closed.
Committed patchset #7 (id:120001)
Message was sent while issue was closed.
Description was changed from ========== Change Skia-related proto enums to uppercase This CL changes Skia-related enums defined in .proto-files to use uppercase, and also remove the Enum_ prefix. This is done as a follow-up to another CL dealing with serialization: https://codereview.chromium.org/1490513005/ The argument for doing this is to keep a consistent style, and Chromium's style guide uses ALL_UPPERCASE for enum values. BUG=561210 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel ========== to ========== Change Skia-related proto enums to uppercase This CL changes Skia-related enums defined in .proto-files to use uppercase, and also remove the Enum_ prefix. This is done as a follow-up to another CL dealing with serialization: https://codereview.chromium.org/1490513005/ The argument for doing this is to keep a consistent style, and Chromium's style guide uses ALL_UPPERCASE for enum values. BUG=561210 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/ac756a7db81feb6a0c29821a598dd679c6a837d3 Cr-Commit-Position: refs/heads/master@{#391118} ==========
Message was sent while issue was closed.
Patchset 7 (id:??) landed as https://crrev.com/ac756a7db81feb6a0c29821a598dd679c6a837d3 Cr-Commit-Position: refs/heads/master@{#391118} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
