Document ProcessSignal::watch.

runtime/bin/process_patch.dart

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 patch class _WindowsCodePageDecoder {
   /* patch */ static String _decodeBytes(List<int> bytes)
       native "SystemEncodingToString";
 }
 
 
@@ skipping 112 matching lines @@
 
 patch class _ProcessUtils {
   /* patch */ static void _exit(int status) native "Process_Exit";
   /* patch */ static void _setExitCode(int status)
       native "Process_SetExitCode";
   /* patch */ static void _sleep(int millis) native "Process_Sleep";
   /* patch */ static int _pid(Process process) native "Process_Pid";
   /* patch */ static Stream<ProcessSignal> _watchSignal(ProcessSignal signal) {
     if (signal != ProcessSignal.SIGHUP &&
         signal != ProcessSignal.SIGINT &&
+        signal != ProcessSignal.SIGTERM &&

[Bob Nystrom, 2014/02/07 18:20:52]

Drive-by comment:

This looks like it's adding support for something new, but I don't see any tests
in this patch. That means to me that there is effectively an untested feature
here. If this is something dart:io officially supports, shouldn't it be tested?

[Anders Johnsen, 2014/02/13 10:43:34]

Partly, signals are indeed tested, but not SIGTERM specifically. Added test.

         (Platform.isWindows ||
          (signal != ProcessSignal.SIGUSR1 &&
           signal != ProcessSignal.SIGUSR2 &&
           signal != ProcessSignal.SIGWINCH))) {
       throw new SignalException(
           "Listening for signal $signal is not supported");
     }
     if (_signalControllers[signal._signalNumber] == null) {
       _signalControllers[signal._signalNumber] = new _SignalController(signal);
     }
@@ skipping 389 matching lines @@
   const _ProcessResult(int this.pid,
                        int this.exitCode,
                        this.stdout,
                        this.stderr);
 
   final int pid;
   final int exitCode;
   final stdout;
   final stderr;
 }