Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(620)

Issue 149253010: Tests and fixes for (pre)parse errors related to strict reserved words. (Closed)

Created:
6 years, 10 months ago by marja
Modified:
6 years, 10 months ago
Reviewers:
ulan
CC:
v8-dev, Michael Starzinger
Visibility:
Public.

Description

Tests and fixes for (pre)parse errors related to strict reserved words. This contains the following fixes: - We had strict_reserved_word and unexpected_strict_reserved, which one to use was totally mixed in Parser and PreParser. Removed strict_reserved_word. - When we saw a strict future reserved word when expecting something completely different (such as "(" in "function foo interface"), Parser reports unexpected identifier, whereas PreParser used to report unexpected strict reserved word. Fixed PreParser to report unexpected identifier too. - Unified parser and preparser error locations when the name of a function is a strict reserved word. Now both point to the name. BUG=3126 LOG=N R=ulan@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=19067

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+202 lines, -52 lines) Patch
M src/messages.js View 1 chunk +0 lines, -1 line 0 comments Download
M src/parser.cc View 1 chunk +2 lines, -6 lines 0 comments Download
M src/preparser.cc View 4 chunks +6 lines, -4 lines 0 comments Download
M test/cctest/test-parsing.cc View 5 chunks +194 lines, -41 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
marja
ulan, ptal
6 years, 10 months ago (2014-02-04 12:07:18 UTC) #1
ulan
lgtm
6 years, 10 months ago (2014-02-04 12:14:42 UTC) #2
marja
6 years, 10 months ago (2014-02-04 12:20:02 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r19067 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698