Issue 149253008: Cast:Refactoring AudioSender to Clang format

Issue 149253008: Cast:Refactoring AudioSender to Clang format (Closed)

Created:
6 years, 10 months ago by mikhal1

Modified:
6 years, 10 months ago

Reviewers:
hubbe

CC:
chromium-reviews, hclam+watch_chromium.org, mikhal+watch_chromium.org, hguihot+watch_chromium.org, jasonroberts+watch_google.com, pwestin+watch_google.com, feature-media-reviews_chromium.org, hubbe+watch_chromium.org, miu+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Cast: Refactor AudioSender to Clang format This cl is pure style-targeted refactoring. No functional changes were made. BUG=339176 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=247907

Patch Set 1 #

Total comments: 2

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+235 lines, -202 lines)			Patch
M	media/cast/audio_sender/audio_encoder.cc	View	13 chunks	+74 lines, -46 lines	0 comments	Download
M	media/cast/audio_sender/audio_encoder_unittest.cc	View	5 chunks	+77 lines, -80 lines	2 comments	Download
M	media/cast/audio_sender/audio_sender.cc	View	7 chunks	+49 lines, -43 lines	0 comments	Download
M	media/cast/audio_sender/audio_sender_unittest.cc	View	5 chunks	+35 lines, -33 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

hubbe

LGTM One optional comment. https://chromiumcodereview.appspot.com/149253008/diff/1/media/cast/audio_sender/audio_encoder_unittest.cc File media/cast/audio_sender/audio_encoder_unittest.cc (right): https://chromiumcodereview.appspot.com/149253008/diff/1/media/cast/audio_sender/audio_encoder_unittest.cc#newcode195 media/cast/audio_sender/audio_encoder_unittest.cc:195: static const int64 kManyCalls_3Millis[] = ...

6 years, 10 months ago (2014-01-29 20:12:20 UTC) #2

mikhal1

https://chromiumcodereview.appspot.com/149253008/diff/1/media/cast/audio_sender/audio_encoder_unittest.cc File media/cast/audio_sender/audio_encoder_unittest.cc (right): https://chromiumcodereview.appspot.com/149253008/diff/1/media/cast/audio_sender/audio_encoder_unittest.cc#newcode195 media/cast/audio_sender/audio_encoder_unittest.cc:195: static const int64 kManyCalls_3Millis[] = {3, 3, 3, 3, ...

6 years, 10 months ago (2014-01-29 20:53:43 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mikhal@chromium.org/149253008/1

6 years, 10 months ago (2014-01-29 20:55:16 UTC) #4

Message was sent while issue was closed.

Change committed as 247907

Expand Messages | Collapse Messages