Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(958)

Issue 1492523004: Fixes #378 (Closed)

Created:
5 years ago by vsm
Modified:
5 years ago
Reviewers:
Jennifer Messerly
CC:
dev-compiler+reviews_dartlang.org
Base URL:
https://github.com/dart-lang/dev_compiler.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fixes #378 Handles fields on "extension" types See patch #1 for the test without the fix. R=jmesserly@google.com Committed: https://github.com/dart-lang/dev_compiler/commit/44741aa57559de07261e26b2ecb0f7ce3071f455

Patch Set 1 #

Patch Set 2 : Use virtual fields for extension fields #

Unified diffs Side-by-side diffs Delta from patch set Stats (+344 lines, -10 lines) Patch
M lib/src/codegen/js_codegen.dart View 1 4 chunks +3 lines, -3 lines 0 comments Download
M lib/src/codegen/js_field_storage.dart View 1 3 chunks +11 lines, -5 lines 0 comments Download
A test/codegen/expect/collection/src/comparators.js View 1 chunk +299 lines, -0 lines 0 comments Download
A test/codegen/expect/collection/src/comparators.txt View 1 chunk +1 line, -0 lines 0 comments Download
A test/codegen/expect/extensions.js View 1 1 chunk +25 lines, -0 lines 0 comments Download
A test/codegen/expect/extensions.txt View 1 chunk +1 line, -0 lines 0 comments Download
A + test/codegen/extensions.dart View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
vsm
5 years ago (2015-12-01 20:57:21 UTC) #3
Jennifer Messerly
lgtm
5 years ago (2015-12-01 23:25:09 UTC) #4
vsm
5 years ago (2015-12-01 23:58:03 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
44741aa57559de07261e26b2ecb0f7ce3071f455 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698