Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Issue 1492523003: Drop [LegacyInterfaceTypeChecking] for HTMLInputElement.prototype.files (Closed)

Created:
5 years ago by philipj_slow
Modified:
5 years ago
CC:
blink-reviews, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Drop [LegacyInterfaceTypeChecking] for HTMLInputElement.prototype.files The setter is non-standard, but if it is standardized it wouldn't make sense to have the existing behavior. For any case that this starts throwing there's a programming error, so unless it breaks the web it should throw TypeError. BUG=561338 Committed: https://crrev.com/c4a4737016177ece7b8f9d607d436eb2838d2365 Cr-Commit-Position: refs/heads/master@{#362689}

Patch Set 1 #

Patch Set 2 : update test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -5 lines) Patch
M third_party/WebKit/LayoutTests/fast/forms/file/input-file-write-files.html View 1 1 chunk +2 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/forms/file/input-file-write-files-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/HTMLInputElement.idl View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1492523003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1492523003/20001
5 years ago (2015-12-02 10:01:01 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years ago (2015-12-02 11:53:10 UTC) #4
philipj_slow
PTAL and CQ?
5 years ago (2015-12-02 12:26:08 UTC) #6
jochen (gone - plz use gerrit)
lgtm
5 years ago (2015-12-02 12:30:20 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1492523003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1492523003/20001
5 years ago (2015-12-02 12:30:28 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years ago (2015-12-02 12:34:05 UTC) #10
commit-bot: I haz the power
5 years ago (2015-12-02 12:34:46 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c4a4737016177ece7b8f9d607d436eb2838d2365
Cr-Commit-Position: refs/heads/master@{#362689}

Powered by Google App Engine
This is Rietveld 408576698