Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(581)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1492503002: win: Fix debug iterator failure on empty database read/write (Closed)

Created:
5 years ago by scottmg
Modified:
5 years ago
CC:
crashpad-dev_chromium.org
Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master
Target Ref:
refs/heads/master
Project:
crashpad
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Patch Set 4 : . #

Patch Set 5 : reading too #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -17 lines) Patch
M client/crash_report_database_test.cc View 1 2 3 4 1 chunk +30 lines, -0 lines 0 comments Download
M client/crash_report_database_win.cc View 1 2 3 4 2 chunks +23 lines, -17 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
scottmg
5 years ago (2015-12-01 18:08:24 UTC) #3
scottmg
Sorry, one sec, I only fixed the write, but it'll happen on read too.
5 years ago (2015-12-01 18:10:04 UTC) #4
scottmg
OK, test and fix for both read and write now.
5 years ago (2015-12-01 18:17:01 UTC) #5
Mark Mentovai
LGTM
5 years ago (2015-12-01 18:25:42 UTC) #7
Robert Sesek
LGTM
5 years ago (2015-12-01 18:25:56 UTC) #8
scottmg
5 years ago (2015-12-01 18:33:31 UTC) #10
Message was sent while issue was closed. 
Committed patchset #5 (id:80001) manually as
72d6be5cb9d94d24eef3a3b95d8bfa22cfd460ce (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698