Decide on IsFinishedParsingChilden for flag name

Decide on IsFinishedParsingChilden for flag name

It seems isFinishedParsingChildren was added because isParsingChildrenFinished is protected in Node.
However we can just choose one name in Node and declare the chosen Node method public in Element.

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=166171

[rwlbuis, 2014-01-29 23:42:36]

Simple cleanup but makes for less confusion about the name. The chosen name is
my preference but I would be ok with the other too.

[Inactive, 2014-01-30 00:47:37]

I am not a native English speaker so I couldn't tell you which naming is better.
I'll let Adamk decide :)

[adamk, 2014-01-30 01:01:23]

IsFinishedParsingChildren reads better to me too.

https://codereview.chromium.org/149243006/diff/1/Source/core/dom/Node.h
File Source/core/dom/Node.h (left):

https://codereview.chromium.org/149243006/diff/1/Source/core/dom/Node.h#oldco...
Source/core/dom/Node.h:118: friend class Document;
This change looks unrelated

[rwlbuis, 2014-01-30 01:35:03]

On 2014/01/30 01:01:23, adamk wrote:
> IsFinishedParsingChildren reads better to me too.

Good!

> https://codereview.chromium.org/149243006/diff/1/Source/core/dom/Node.h
> File Source/core/dom/Node.h (left):
> 
>
https://codereview.chromium.org/149243006/diff/1/Source/core/dom/Node.h#oldco...
> Source/core/dom/Node.h:118: friend class Document;
> This change looks unrelated

It kind of is, I just was not sure if such a one-liner change needs its own CL.
I can remove it if you prefer.

[adamk, 2014-01-30 01:37:38]

On 2014/01/30 01:35:03, rwlbuis wrote:
> On 2014/01/30 01:01:23, adamk wrote:
> > IsFinishedParsingChildren reads better to me too.
> 
> Good!
> 
> > https://codereview.chromium.org/149243006/diff/1/Source/core/dom/Node.h
> > File Source/core/dom/Node.h (left):
> > 
> >
>
https://codereview.chromium.org/149243006/diff/1/Source/core/dom/Node.h#oldco...
> > Source/core/dom/Node.h:118: friend class Document;
> > This change looks unrelated
> 
> It kind of is, I just was not sure if such a one-liner change needs its own
CL.
> I can remove it if you prefer.

lgtm if you remove the that line from the patch, it does seem separate from the
renaming of IsFinishedParsingChildren. (I'm also a little surprised it works, I
thought I tried this a week ago and it didn't build for me. But your trybots say
otherwise.)

[commit-bot: I haz the power, 2014-01-30 14:38:35]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rob.buis@samsung.com/149243006/20001

[commit-bot: I haz the power, 2014-01-30 19:04:00]

Retried try job too often on win_blink_rel for step(s) blink_heap_unittests,
blink_platform_unittests, webkit_lint, webkit_python_tests, webkit_unit_tests,
wtf_unittests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_blink_...

[commit-bot: I haz the power, 2014-01-30 19:04:02]

CQ bit was unchecked on CL. Ignoring.

[commit-bot: I haz the power, 2014-01-30 19:04:03]

CQ bit was unchecked on CL. Ignoring.

[commit-bot: I haz the power, 2014-01-30 19:17:03]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rob.buis@samsung.com/149243006/20001

[commit-bot: I haz the power, 2014-01-30 19:36:05]

Change committed as 166171

[commit-bot: I haz the power, 2014-01-30 19:36:09]

CQ bit was unchecked on CL. Ignoring.

[commit-bot: I haz the power, 2014-01-30 19:36:47]

CQ bit was unchecked on CL. Ignoring.