Issue 149243005: Files.app: Ignore FILE_ERROR_ABORT error when sync update.

Issue 149243005: Files.app: Ignore FILE_ERROR_ABORT error when sync update. (Closed)

Created:
6 years, 10 months ago by hirono

Modified:
6 years, 10 months ago

Reviewers:
hashimoto

CC:
chromium-reviews, tfarina, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Files.app: Ignore FILE_ERROR_ABORT error when sync update. Previously FILE_ERROR_ABORT that is happened by user's cancel operations raises the general error message. BUG=339028 TEST=manually Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=247883

Patch Set 1 #

Total comments: 2

Patch Set 2 : Remove an empty line. #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -0 lines)			Patch
	M	chrome/browser/chromeos/drive/sync_client.cc	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

hashimoto

lgtm https://codereview.chromium.org/149243005/diff/1/chrome/browser/chromeos/drive/sync_client.cc File chrome/browser/chromeos/drive/sync_client.cc (right): https://codereview.chromium.org/149243005/diff/1/chrome/browser/chromeos/drive/sync_client.cc#newcode415 chrome/browser/chromeos/drive/sync_client.cc:415: nit: This blank line is not needed.

6 years, 10 months ago (2014-01-29 08:35:18 UTC) #2

hirono

Thanks! https://codereview.chromium.org/149243005/diff/1/chrome/browser/chromeos/drive/sync_client.cc File chrome/browser/chromeos/drive/sync_client.cc (right): https://codereview.chromium.org/149243005/diff/1/chrome/browser/chromeos/drive/sync_client.cc#newcode415 chrome/browser/chromeos/drive/sync_client.cc:415: On 2014/01/29 08:35:19, hashimoto wrote: > nit: This ...

6 years, 10 months ago (2014-01-29 10:35:31 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hirono@chromium.org/149243005/20001

6 years, 10 months ago (2014-01-29 10:35:35 UTC) #4

commit-bot: I haz the power

Retried try job too often on win_rel for step(s) unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=253404

6 years, 10 months ago (2014-01-29 11:26:30 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hirono@chromium.org/149243005/20001

6 years, 10 months ago (2014-01-30 02:12:22 UTC) #6

Message was sent while issue was closed.

Change committed as 247883

Expand Messages | Collapse Messages