Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Issue 149243002: Roll gyp 1842:1846 (Closed)

Created:
6 years, 10 months ago by hans
Modified:
6 years, 10 months ago
Reviewers:
Nico
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Roll gyp 1842:1846 r1843: Xcode: Add .xcassets = folder.assetcatalog in extension_map r1844: Eclipse generator now uses compiler's default include dirs r1845: Quell warnings for exclusion list dictionaries in MSVS generator r1846: Ninja generator: support using clang-cl for Windows BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=247638

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
hans
Gyp bots looking happy: http://build.chromium.org/f/client/gyp/
6 years, 10 months ago (2014-01-28 23:19:37 UTC) #1
Nico
Please make the commit message look like http://svnsearch.org/svnsearch/repos/CHROMIUM/search?logMessage=%22roll%20gyp%22 On Tue, Jan 28, 2014 at 3:19 ...
6 years, 10 months ago (2014-01-28 23:22:50 UTC) #2
hans
On 2014/01/28 23:22:50, Nico wrote: > Please make the commit message look like > http://svnsearch.org/svnsearch/repos/CHROMIUM/search?logMessage=%2522roll%2520gyp%2522 ...
6 years, 10 months ago (2014-01-28 23:24:50 UTC) #3
Nico
lgtm
6 years, 10 months ago (2014-01-29 00:03:42 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hans@chromium.org/149243002/1
6 years, 10 months ago (2014-01-29 00:07:11 UTC) #5
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) remoting_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=217572
6 years, 10 months ago (2014-01-29 01:03:32 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hans@chromium.org/149243002/1
6 years, 10 months ago (2014-01-29 01:10:00 UTC) #7
commit-bot: I haz the power
6 years, 10 months ago (2014-01-29 06:04:11 UTC) #8
Message was sent while issue was closed.
Change committed as 247638

Powered by Google App Engine
This is Rietveld 408576698