Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4376)

Unified Diff: chrome/browser/themes/theme_properties.cc

Issue 1492423003: Rejigger ThemeService: move exposure of ThemeProvider interface to a (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix that unittest Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/themes/theme_properties.h ('k') | chrome/browser/themes/theme_service.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/themes/theme_properties.cc
diff --git a/chrome/browser/themes/theme_properties.cc b/chrome/browser/themes/theme_properties.cc
index 2ea97c9665664505005d5235da1455845b743795..a4b95d813504073ca2b9cf6c78f700188868e064 100644
--- a/chrome/browser/themes/theme_properties.cc
+++ b/chrome/browser/themes/theme_properties.cc
@@ -45,6 +45,8 @@ const SkColor kDefaultColorToolbar = SkColorSetRGB(230, 230, 230);
#else
const SkColor kDefaultColorToolbar[] = {
SkColorSetRGB(223, 223, 223), SkColorSetRGB(242, 242, 242)};
+const SkColor kDefaultColorToolbarIncognito[] = {
+ SkColorSetRGB(223, 223, 223), SkColorSetRGB(0x50, 0x50, 0x50)};
#endif // OS_MACOSX
const SkColor kDefaultColorTabText = SK_ColorBLACK;
@@ -240,6 +242,10 @@ color_utils::HSL ThemeProperties::GetDefaultTint(int id) {
// static
SkColor ThemeProperties::GetDefaultColor(int id) {
+ return GetDefaultColor(id, false);
+}
+
+SkColor ThemeProperties::GetDefaultColor(int id, bool otr) {
int mode = ui::MaterialDesignController::IsModeMaterial();
switch (id) {
// Properties stored in theme pack.
@@ -259,11 +265,13 @@ SkColor ThemeProperties::GetDefaultColor(int id) {
return kDefaultColorFrameIncognito[mode];
case COLOR_FRAME_INCOGNITO_INACTIVE:
return kDefaultColorFrameIncognitoInactive[mode];
- case COLOR_TOOLBAR:
#if defined(OS_MACOSX)
+ case COLOR_TOOLBAR:
return kDefaultColorToolbar;
#else
- return kDefaultColorToolbar[mode];
+ case COLOR_TOOLBAR:
+ return otr ? kDefaultColorToolbarIncognito[mode]
+ : kDefaultColorToolbar[mode];
#endif // OS_MACOSX
case COLOR_TAB_TEXT:
return kDefaultColorTabText;
« no previous file with comments | « chrome/browser/themes/theme_properties.h ('k') | chrome/browser/themes/theme_service.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698