chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm - Issue 1492423003: Rejigger ThemeService: move exposure of ThemeProvider interface to a

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm

Issue 1492423003: Rejigger ThemeService: move exposure of ThemeProvider interface to a (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fixes? Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/themes/theme_service_unittest.cc ('k') | chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_controller.mm » ('j') | chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_controller.mm » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm

diff --git a/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm b/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm

index 96aedc5b4c84f6e8d864b1d9da268232acd0a8be..b13de1a477cfea96c3b352523ba24aac6ef2d70c 100644

--- a/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm

+++ b/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm

@@ -2456,8 +2456,8 @@ static BOOL ValueInRangeInclusive(CGFloat low, CGFloat value, CGFloat high) {

return NSHeight([[browserController tabContentArea] frame]);

}

-- (ThemeService*)themeService {

- return ThemeServiceFactory::GetForProfile(browser_->profile());

+- (Profile*)profile {

groby-ooo-7-16 2015/12/11 02:32:00 Do we need this method at all? The protocol is on

Evan Stade 2015/12/11 19:36:58 but where it's used, it's cast as a BookmarkBarToo

+ return browser_->profile();

}

#pragma mark BookmarkButtonDelegate Protocol