Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(384)

Unified Diff: ui/base/theme_provider.h

Issue 1492423003: Rejigger ThemeService: move exposure of ThemeProvider interface to a (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: add a test Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/base/theme_provider.h
diff --git a/ui/base/theme_provider.h b/ui/base/theme_provider.h
index eeab83d796cec946111e04a1a112a835362bbe46..113a3ac83313014400b6319616e9a3ead0e464d5 100644
--- a/ui/base/theme_provider.h
+++ b/ui/base/theme_provider.h
@@ -47,10 +47,6 @@ class UI_BASE_EXPORT ThemeProvider {
public:
virtual ~ThemeProvider();
- // Whether we're using the system theme (which may or may not be the
- // same as the default theme).
- virtual bool UsingSystemTheme() const = 0;
-
// Get the image specified by |id|. An implementation of ThemeProvider should
// have its own source of ids (e.g. an enum, or external resource bundle).
virtual gfx::ImageSkia* GetImageSkiaNamed(int id) const = 0;
@@ -78,6 +74,11 @@ class UI_BASE_EXPORT ThemeProvider {
ui::ScaleFactor scale_factor) const = 0;
#if defined(OS_MACOSX)
+ // Whether we're using the system theme (which may or may not be the
+ // same as the default theme). TODO(estade): this should probably just be part
pkotwicz 2015/12/04 23:16:50 Nit: TODO on new line
Evan Stade 2015/12/09 00:57:11 Done.
+ // of ThemeService and not ThemeProvider, but it's used in many places on OSX.
+ virtual bool UsingSystemTheme() const = 0;
+
// Gets the NSImage with the specified |id|.
virtual NSImage* GetNSImageNamed(int id) const = 0;
« chrome/browser/ui/webui/theme_source.cc ('K') | « ui/base/default_theme_provider_mac.mm ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698