Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Unified Diff: chrome/browser/ui/views/toolbar/toolbar_button.cc

Issue 1492423003: Rejigger ThemeService: move exposure of ThemeProvider interface to a (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: add a test Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/toolbar/toolbar_button.cc
diff --git a/chrome/browser/ui/views/toolbar/toolbar_button.cc b/chrome/browser/ui/views/toolbar/toolbar_button.cc
index 03bf129c996ce1377060ae586997e0aaa88a0389..0d376d3d6775f78ba6e3a3a43cfde3c8c7c5e37f 100644
--- a/chrome/browser/ui/views/toolbar/toolbar_button.cc
+++ b/chrome/browser/ui/views/toolbar/toolbar_button.cc
@@ -8,6 +8,9 @@
#include "base/location.h"
#include "base/single_thread_task_runner.h"
#include "base/thread_task_runner_handle.h"
+#include "chrome/browser/profiles/profile.h"
+#include "chrome/browser/themes/theme_service.h"
+#include "chrome/browser/themes/theme_service_factory.h"
#include "chrome/browser/ui/views/layout_constants.h"
#include "chrome/browser/ui/views/location_bar/location_bar_view.h"
#include "ui/accessibility/ax_view_state.h"
@@ -26,9 +29,11 @@
#include "ui/views/controls/menu/menu_runner.h"
#include "ui/views/widget/widget.h"
-ToolbarButton::ToolbarButton(views::ButtonListener* listener,
+ToolbarButton::ToolbarButton(Profile* profile,
+ views::ButtonListener* listener,
ui::MenuModel* model)
: views::LabelButton(listener, base::string16()),
+ profile_(profile),
model_(model),
menu_showing_(false),
y_position_on_lbuttondown_(0),
@@ -201,8 +206,9 @@ ToolbarButton::CreateDefaultBorder() const {
scoped_ptr<views::LabelButtonBorder> border =
views::LabelButton::CreateDefaultBorder();
- const ui::ThemeProvider* provider = GetThemeProvider();
- if (provider && provider->UsingSystemTheme())
+ const ThemeService* theme_service =
+ ThemeServiceFactory::GetForProfile(profile_);
+ if (theme_service->UsingSystemTheme())
border->set_insets(GetLayoutInsets(TOOLBAR_BUTTON));
return border.Pass();

Powered by Google App Engine
This is Rietveld 408576698