Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1163)

Side by Side Diff: extensions/browser/api/cast_channel/cast_framer.cc

Issue 1492403002: Remove kuint32max. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: http security header file Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « extensions/browser/api/cast_channel/cast_framer.h ('k') | media/audio/audio_device_thread.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "extensions/browser/api/cast_channel/cast_framer.h" 5 #include "extensions/browser/api/cast_channel/cast_framer.h"
6 6
7 #include <stdlib.h> 7 #include <stdlib.h>
8 8
9 #include <limits>
10
9 #include "base/numerics/safe_conversions.h" 11 #include "base/numerics/safe_conversions.h"
10 #include "base/strings/string_number_conversions.h" 12 #include "base/strings/string_number_conversions.h"
11 #include "base/sys_byteorder.h" 13 #include "base/sys_byteorder.h"
12 #include "extensions/common/api/cast_channel/cast_channel.pb.h" 14 #include "extensions/common/api/cast_channel/cast_channel.pb.h"
13 15
14 namespace extensions { 16 namespace extensions {
15 namespace api { 17 namespace api {
16 namespace cast_channel { 18 namespace cast_channel {
17 MessageFramer::MessageFramer(scoped_refptr<net::GrowableIOBuffer> input_buffer) 19 MessageFramer::MessageFramer(scoped_refptr<net::GrowableIOBuffer> input_buffer)
18 : input_buffer_(input_buffer), error_(false) { 20 : input_buffer_(input_buffer), error_(false) {
19 Reset(); 21 Reset();
20 } 22 }
21 23
22 MessageFramer::~MessageFramer() { 24 MessageFramer::~MessageFramer() {
23 } 25 }
24 26
25 MessageFramer::MessageHeader::MessageHeader() : message_size(0) { 27 MessageFramer::MessageHeader::MessageHeader() : message_size(0) {
26 } 28 }
27 29
28 void MessageFramer::MessageHeader::SetMessageSize(size_t size) { 30 void MessageFramer::MessageHeader::SetMessageSize(size_t size) {
29 DCHECK_LT(size, static_cast<size_t>(kuint32max)); 31 DCHECK_LT(size, static_cast<size_t>(std::numeric_limits<uint32_t>::max()));
30 DCHECK_GT(size, 0U); 32 DCHECK_GT(size, 0U);
31 message_size = size; 33 message_size = size;
32 } 34 }
33 35
34 // TODO(mfoltz): Investigate replacing header serialization with base::Pickle, 36 // TODO(mfoltz): Investigate replacing header serialization with base::Pickle,
35 // if bit-for-bit compatible. 37 // if bit-for-bit compatible.
36 void MessageFramer::MessageHeader::PrependToString(std::string* str) { 38 void MessageFramer::MessageHeader::PrependToString(std::string* str) {
37 MessageHeader output = *this; 39 MessageHeader output = *this;
38 output.message_size = base::HostToNet32(message_size); 40 output.message_size = base::HostToNet32(message_size);
39 size_t header_size = MessageHeader::header_size(); 41 size_t header_size = MessageHeader::header_size();
40 scoped_ptr<char, base::FreeDeleter> char_array( 42 scoped_ptr<char, base::FreeDeleter> char_array(
41 static_cast<char*>(malloc(header_size))); 43 static_cast<char*>(malloc(header_size)));
42 memcpy(char_array.get(), &output, header_size); 44 memcpy(char_array.get(), &output, header_size);
43 str->insert(0, char_array.get(), header_size); 45 str->insert(0, char_array.get(), header_size);
44 } 46 }
45 47
46 // TODO(mfoltz): Investigate replacing header deserialization with base::Pickle, 48 // TODO(mfoltz): Investigate replacing header deserialization with base::Pickle,
47 // if bit-for-bit compatible. 49 // if bit-for-bit compatible.
48 void MessageFramer::MessageHeader::Deserialize(char* data, 50 void MessageFramer::MessageHeader::Deserialize(char* data,
49 MessageHeader* header) { 51 MessageHeader* header) {
50 uint32 message_size; 52 uint32_t message_size;
51 memcpy(&message_size, data, header_size()); 53 memcpy(&message_size, data, header_size());
52 header->message_size = 54 header->message_size =
53 base::checked_cast<size_t>(base::NetToHost32(message_size)); 55 base::checked_cast<size_t>(base::NetToHost32(message_size));
54 } 56 }
55 57
56 // static 58 // static
57 size_t MessageFramer::MessageHeader::header_size() { 59 size_t MessageFramer::MessageHeader::header_size() {
58 return sizeof(uint32); 60 return sizeof(uint32_t);
59 } 61 }
60 62
61 // static 63 // static
62 size_t MessageFramer::MessageHeader::max_message_size() { 64 size_t MessageFramer::MessageHeader::max_message_size() {
63 return 65535; 65 return 65535;
64 } 66 }
65 67
66 std::string MessageFramer::MessageHeader::ToString() { 68 std::string MessageFramer::MessageHeader::ToString() {
67 return "{message_size: " + 69 return "{message_size: " +
68 base::UintToString(static_cast<uint32>(message_size)) + "}"; 70 base::UintToString(static_cast<uint32_t>(message_size)) + "}";
69 } 71 }
70 72
71 // static 73 // static
72 bool MessageFramer::Serialize(const CastMessage& message_proto, 74 bool MessageFramer::Serialize(const CastMessage& message_proto,
73 std::string* message_data) { 75 std::string* message_data) {
74 DCHECK(message_data); 76 DCHECK(message_data);
75 message_proto.SerializeToString(message_data); 77 message_proto.SerializeToString(message_data);
76 size_t message_size = message_data->size(); 78 size_t message_size = message_data->size();
77 if (message_size > MessageHeader::max_message_size()) { 79 if (message_size > MessageHeader::max_message_size()) {
78 message_data->clear(); 80 message_data->clear();
(...skipping 34 matching lines...) Expand 10 before | Expand all | Expand 10 after
113 scoped_ptr<CastMessage> MessageFramer::Ingest(size_t num_bytes, 115 scoped_ptr<CastMessage> MessageFramer::Ingest(size_t num_bytes,
114 size_t* message_length, 116 size_t* message_length,
115 ChannelError* error) { 117 ChannelError* error) {
116 DCHECK(error); 118 DCHECK(error);
117 DCHECK(message_length); 119 DCHECK(message_length);
118 if (error_) { 120 if (error_) {
119 *error = CHANNEL_ERROR_INVALID_MESSAGE; 121 *error = CHANNEL_ERROR_INVALID_MESSAGE;
120 return scoped_ptr<CastMessage>(); 122 return scoped_ptr<CastMessage>();
121 } 123 }
122 124
123 DCHECK_EQ(base::checked_cast<int32>(message_bytes_received_), 125 DCHECK_EQ(base::checked_cast<int32_t>(message_bytes_received_),
124 input_buffer_->offset()); 126 input_buffer_->offset());
125 CHECK_LE(num_bytes, BytesRequested()); 127 CHECK_LE(num_bytes, BytesRequested());
126 message_bytes_received_ += num_bytes; 128 message_bytes_received_ += num_bytes;
127 *error = CHANNEL_ERROR_NONE; 129 *error = CHANNEL_ERROR_NONE;
128 *message_length = 0; 130 *message_length = 0;
129 switch (current_element_) { 131 switch (current_element_) {
130 case HEADER: 132 case HEADER:
131 if (BytesRequested() == 0) { 133 if (BytesRequested() == 0) {
132 MessageHeader header; 134 MessageHeader header;
133 MessageHeader::Deserialize(input_buffer_.get()->StartOfBuffer(), 135 MessageHeader::Deserialize(input_buffer_.get()->StartOfBuffer(),
(...skipping 36 matching lines...) Expand 10 before | Expand all | Expand 10 after
170 void MessageFramer::Reset() { 172 void MessageFramer::Reset() {
171 current_element_ = HEADER; 173 current_element_ = HEADER;
172 message_bytes_received_ = 0; 174 message_bytes_received_ = 0;
173 body_size_ = 0; 175 body_size_ = 0;
174 input_buffer_->set_offset(0); 176 input_buffer_->set_offset(0);
175 } 177 }
176 178
177 } // namespace cast_channel 179 } // namespace cast_channel
178 } // namespace api 180 } // namespace api
179 } // namespace extensions 181 } // namespace extensions
OLDNEW
« no previous file with comments | « extensions/browser/api/cast_channel/cast_framer.h ('k') | media/audio/audio_device_thread.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698