Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Side by Side Diff: src/debug/arm/debug-arm.cc

Issue 1492393003: Reland of [debugger] do not restart frames that reference new.target for liveedit. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/ast/scopeinfo.cc ('k') | src/debug/arm64/debug-arm64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if V8_TARGET_ARCH_ARM 5 #if V8_TARGET_ARCH_ARM
6 6
7 #include "src/codegen.h" 7 #include "src/codegen.h"
8 #include "src/debug/debug.h" 8 #include "src/debug/debug.h"
9 9
10 namespace v8 { 10 namespace v8 {
(...skipping 120 matching lines...) Expand 10 before | Expand all | Expand 10 after
131 StandardFrameConstants::kConstantPoolOffset - kPointerSize)); 131 StandardFrameConstants::kConstantPoolOffset - kPointerSize));
132 132
133 // Pop return address, frame and constant pool pointer (if 133 // Pop return address, frame and constant pool pointer (if
134 // FLAG_enable_embedded_constant_pool). 134 // FLAG_enable_embedded_constant_pool).
135 __ LeaveFrame(StackFrame::INTERNAL); 135 __ LeaveFrame(StackFrame::INTERNAL);
136 136
137 { ConstantPoolUnavailableScope constant_pool_unavailable(masm); 137 { ConstantPoolUnavailableScope constant_pool_unavailable(masm);
138 // Load context from the function. 138 // Load context from the function.
139 __ ldr(cp, FieldMemOperand(r1, JSFunction::kContextOffset)); 139 __ ldr(cp, FieldMemOperand(r1, JSFunction::kContextOffset));
140 140
141 // Clear new.target as a safety measure.
142 __ LoadRoot(r3, Heap::kUndefinedValueRootIndex);
143
141 // Get function code. 144 // Get function code.
142 __ ldr(ip, FieldMemOperand(r1, JSFunction::kSharedFunctionInfoOffset)); 145 __ ldr(ip, FieldMemOperand(r1, JSFunction::kSharedFunctionInfoOffset));
143 __ ldr(ip, FieldMemOperand(ip, SharedFunctionInfo::kCodeOffset)); 146 __ ldr(ip, FieldMemOperand(ip, SharedFunctionInfo::kCodeOffset));
144 __ add(ip, ip, Operand(Code::kHeaderSize - kHeapObjectTag)); 147 __ add(ip, ip, Operand(Code::kHeaderSize - kHeapObjectTag));
145 148
146 // Re-run JSFunction, r1 is function, cp is context. 149 // Re-run JSFunction, r1 is function, cp is context.
147 __ Jump(ip); 150 __ Jump(ip);
148 } 151 }
149 } 152 }
150 153
151 154
152 const bool LiveEdit::kFrameDropperSupported = true; 155 const bool LiveEdit::kFrameDropperSupported = true;
153 156
154 #undef __ 157 #undef __
155 158
156 } // namespace internal 159 } // namespace internal
157 } // namespace v8 160 } // namespace v8
158 161
159 #endif // V8_TARGET_ARCH_ARM 162 #endif // V8_TARGET_ARCH_ARM
OLDNEW
« no previous file with comments | « src/ast/scopeinfo.cc ('k') | src/debug/arm64/debug-arm64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698