Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Issue 1492373002: Fix for DeclarationResolver and invalid getters/setters. (Closed)

Created:
5 years ago by scheglov
Modified:
5 years ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix for DeclarationResolver and invalid getters/setters. This fixes the following exception: Caused by The null object does not have a getter 'variable'. NoSuchMethodError: method not found: 'variable' Receiver: null Arguments: [] R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/dc13ac659f067d89a3ac07b4badcab469d841d55

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+111 lines, -6 lines) Patch
M pkg/analyzer/lib/src/generated/resolver.dart View 1 chunk +11 lines, -6 lines 0 comments Download
A pkg/analyzer/test/generated/declaration_resolver_test.dart View 1 chunk +98 lines, -0 lines 0 comments Download
M pkg/analyzer/test/generated/test_all.dart View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
5 years ago (2015-12-03 17:45:32 UTC) #1
Brian Wilkerson
LGTM
5 years ago (2015-12-03 17:56:08 UTC) #2
scheglov
5 years ago (2015-12-03 17:59:06 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
dc13ac659f067d89a3ac07b4badcab469d841d55 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698