Consolidate Windows bitmap and DC code

skia/ext/bitmap_platform_device_win.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <windows.h>
 #include <psapi.h>
 #include <stddef.h>
 
 #include "base/debug/gdi_debug_util_win.h"
 #include "base/logging.h"
 #include "base/win/win_util.h"
 #include "skia/ext/bitmap_platform_device_win.h"
 #include "skia/ext/platform_canvas.h"
 #include "skia/ext/skia_utils_win.h"
 #include "third_party/skia/include/core/SkMatrix.h"
 #include "third_party/skia/include/core/SkPath.h"
 #include "third_party/skia/include/core/SkRefCnt.h"
 #include "third_party/skia/include/core/SkRect.h"
 
 namespace {
 
-HBITMAP CreateHBitmap(int width, int height, bool is_opaque,
-                             HANDLE shared_section, void** data) {
-  // CreateDIBSection appears to get unhappy if we create an empty bitmap, so
-  // just create a minimal bitmap
-  if ((width == 0) || (height == 0)) {
-    width = 1;
-    height = 1;
-  }
-
-  BITMAPINFOHEADER hdr = {0};
-  hdr.biSize = sizeof(BITMAPINFOHEADER);
-  hdr.biWidth = width;
-  hdr.biHeight = -height;  // minus means top-down bitmap
-  hdr.biPlanes = 1;
-  hdr.biBitCount = 32;
-  hdr.biCompression = BI_RGB;  // no compression
-  hdr.biSizeImage = 0;
-  hdr.biXPelsPerMeter = 1;
-  hdr.biYPelsPerMeter = 1;
-  hdr.biClrUsed = 0;
-  hdr.biClrImportant = 0;
-
-  HBITMAP hbitmap = CreateDIBSection(NULL, reinterpret_cast<BITMAPINFO*>(&hdr),
-                                     0, data, shared_section, 0);
-
-#if !defined(_WIN64)
-  // If this call fails, we're gonna crash hard. Try to get some useful
-  // information out before we crash for post-mortem analysis.
-  if (!hbitmap)
-    base::debug::GDIBitmapAllocFailure(&hdr, shared_section);
-#endif
-
-  return hbitmap;
-}
-
 void LoadClippingRegionToDC(HDC context,
                             const SkIRect& clip_bounds,
                             const SkMatrix& transformation) {
   HRGN hrgn = CreateRectRgnIndirect(&skia::SkIRectToRECT(clip_bounds));
   int result = SelectClipRgn(context, hrgn);
   SkASSERT(result != ERROR);
   result = DeleteObject(hrgn);
   SkASSERT(result != 0);
 }
 
@@ skipping 13 matching lines @@
     src_rect = &temp_rect;
   }
   skia::CopyHDC(p.GetPlatformSurface(), destination_hdc, x, y,
                 canvas->imageInfo().isOpaque(), *src_rect,
                 canvas->getTotalMatrix());
 }
 
 HDC BitmapPlatformDevice::GetBitmapDC(const SkMatrix& transform,
                                       const SkIRect& clip_bounds) {
   if (!hdc_) {
-    hdc_ = CreateCompatibleDC(NULL);
-    InitializeDC(hdc_);
+    hdc_ = CreateCompatibleDC(nullptr);
+    skia::InitializeDC(hdc_);
     old_hbitmap_ = static_cast<HBITMAP>(SelectObject(hdc_, hbitmap_));
   }
 
   LoadConfig(transform, clip_bounds);
   return hdc_;
 }
 
 void BitmapPlatformDevice::ReleaseBitmapDC() {
   SkASSERT(hdc_);
   SelectObject(hdc_, old_hbitmap_);
@@ skipping 50 matching lines @@
   void* data;
   HBITMAP hbitmap = NULL;
 
   // This function contains an implementation of a Skia platform bitmap for
   // drawing and compositing graphics. The original implementation uses Windows
   // GDI to create the backing bitmap memory, however it's possible for a
   // process to not have access to GDI which will cause this code to fail. It's
   // possible to detect when GDI is unavailable and instead directly map the
   // shared memory as the bitmap.
   if (base::win::IsUser32AndGdi32Available()) {
-    hbitmap = CreateHBitmap(width, height, is_opaque, shared_section, &data);
+    hbitmap = skia::CreateHBitmap(width, height, shared_section, &data);
     if (!hbitmap) {
       LOG(ERROR) << "CreateHBitmap failed";
       return NULL;
     }
   } else {
     DCHECK(shared_section != NULL);
     data = MapViewOfFile(shared_section, FILE_MAP_WRITE, 0, 0,
                          PlatformCanvasStrideForWidth(width) * height);
     if (!data) {
       LOG(ERROR) << "MapViewOfFile failed";
@@ skipping 75 matching lines @@
 }
 
 // PlatformCanvas impl
 
 SkCanvas* CreatePlatformCanvas(int width,
                                int height,
                                bool is_opaque,
                                HANDLE shared_section,
                                OnFailureType failureType) {
   sk_sp<SkBaseDevice> dev(
-      BitmapPlatformDevice::Create(width, height, is_opaque, shared_section));
+      BitmapPlatformDevice::Create(width, height, shared_section));
   return CreateCanvas(dev, failureType);
 }
 
 }  // namespace skia