Revert "Automatically trigger installation of high-quality speech synthesis extension."

Revert "Automatically trigger installation of high-quality speech synthesis extension."

This reverts commit r241081.

Reason: changing the builtin tts engine to use an event page instead of a persistent background page can cause tts to stop working for some users.

BUG=339322
TBR=dpolukhin@chromium.org, thakis@chromium.org, dtseng@chromium.org, kalman@chromium.org, dmazzoni@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=249559

[Peter Lundblad, 2014-02-06 02:11:49]

The CQ bit was checked by plundblad@chromium.org

[commit-bot: I haz the power, 2014-02-06 02:14:51]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/plundblad@chromium.org/149233004/140001

[Nico, 2014-02-06 02:25:14]

When reverting something, always say why.
On Feb 5, 2014 5:57 PM, <plundblad@chromium.org> wrote:

> Reviewers: Dmitry Polukhin, David Tseng, kalman - OOO, Nico,
>
> Description:
> Revert "Automatically trigger installation of high-quality speech synthesis
> extension."
>
> This reverts commit r241081.
>
> BUG=339322
> TBR=dpolukhin@chromium.org, thakis@chromium.org, dtseng@chromium.org,
> kalman@chromium.org, dmazzoni@chromium.org
>
> Please review this at https://codereview.chromium.org/149233004/
>
> SVN Base: https://chromium.googlesource.com/chromium/src.git@lkgr
>
> Affected files (+247, -370 lines):
>   D chrome/browser/extensions/external_component_loader_unittest.cc
>   M chrome/browser/chromeos/login/user_manager_impl.h
>   M chrome/browser/extensions/component_loader.h
>   M chrome/browser/extensions/component_loader.cc
>   M chrome/browser/extensions/external_component_loader.h
>   M chrome/browser/extensions/external_component_loader.cc
>   M chrome/browser/prefs/browser_prefs.cc
>   M chrome/browser/resources/chromeos/speech_synthesis/manifest.json
>   M chrome/browser/speech/tts_chromeos.cc
>   M chrome/browser/speech/tts_controller.h
>   M chrome/browser/speech/tts_controller.cc
>   A chrome/browser/speech/tts_extension_loader_chromeos.h
>   A chrome/browser/speech/tts_extension_loader_chromeos.cc
>   M chrome/browser/speech/tts_platform.h
>   M chrome/browser/speech/tts_platform.cc
>   M chrome/chrome_browser.gypi
>   M chrome/chrome_tests_unit.gypi
>   M chrome/common/extensions/extension_constants.h
>   M chrome/common/extensions/extension_constants.cc
>   M chrome/common/pref_names.h
>   M chrome/common/pref_names.cc
>
>
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Peter Lundblad, 2014-02-06 02:36:21]

Nico Weber writes:
> When reverting something, always say why.

Updated the description with a brief justification. Lots of info in the bug as
well.

//Peter


> On Feb 5, 2014 5:57 PM, <plundblad@chromium.org> wrote:
> 
>     Reviewers: Dmitry Polukhin, David Tseng, kalman - OOO, Nico,
> 
>     Description:
>     Revert "Automatically trigger installation of high-quality speech
synthesis
>     extension."
> 
>     This reverts commit r241081.
> 
>     BUG=339322
>     TBR=dpolukhin@chromium.org, thakis@chromium.org, dtseng@chromium.org,
>     kalman@chromium.org, dmazzoni@chromium.org
> 
>     Please review this at https://codereview.chromium.org/149233004/
> 
>     SVN Base: https://chromium.googlesource.com/chromium/src.git@lkgr
> 
>     Affected files (+247, -370 lines):
>       D chrome/browser/extensions/external_component_loader_unittest.cc
>       M chrome/browser/chromeos/login/user_manager_impl.h
>       M chrome/browser/extensions/component_loader.h
>       M chrome/browser/extensions/component_loader.cc
>       M chrome/browser/extensions/external_component_loader.h
>       M chrome/browser/extensions/external_component_loader.cc
>       M chrome/browser/prefs/browser_prefs.cc
>       M chrome/browser/resources/chromeos/speech_synthesis/manifest.json
>       M chrome/browser/speech/tts_chromeos.cc
>       M chrome/browser/speech/tts_controller.h
>       M chrome/browser/speech/tts_controller.cc
>       A chrome/browser/speech/tts_extension_loader_chromeos.h
>       A chrome/browser/speech/tts_extension_loader_chromeos.cc
>       M chrome/browser/speech/tts_platform.h
>       M chrome/browser/speech/tts_platform.cc
>       M chrome/chrome_browser.gypi
>       M chrome/chrome_tests_unit.gypi
>       M chrome/common/extensions/extension_constants.h
>       M chrome/common/extensions/extension_constants.cc
>       M chrome/common/pref_names.h
>       M chrome/common/pref_names.cc
> 
> 
> 

-- 

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[commit-bot: I haz the power, 2014-02-06 06:01:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-02-06 06:01:02]

Retried try job too often on linux_chromeos for step(s) app_list_unittests,
ash_unittests, aura_unittests, base_unittests, browser_tests,
cacheinvalidation_unittests, check_deps, check_deps2git, chromeos_unittests,
components_unittests, content_browsertests, content_unittests, crypto_unittests,
dbus_unittests, device_unittests, events_unittests, google_apis_unittests,
gpu_unittests, interactive_ui_tests, ipc_tests, jingle_unittests,
media_unittests, net_unittests, ppapi_unittests, printing_unittests,
sandbox_linux_unittests, sql_unittests, sync_unit_tests, unit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...

[Peter Lundblad, 2014-02-06 16:26:37]

The CQ bit was checked by plundblad@chromium.org

[commit-bot: I haz the power, 2014-02-06 16:27:22]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/plundblad@chromium.org/149233004/430001

[commit-bot: I haz the power, 2014-02-06 17:26:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-02-06 17:26:19]

Retried try job too often on android_aosp for step(s) compile
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_ao...

[Peter Lundblad, 2014-02-06 18:06:57]

The CQ bit was checked by plundblad@chromium.org

[commit-bot: I haz the power, 2014-02-06 18:07:21]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/plundblad@chromium.org/149233004/430001

[commit-bot: I haz the power, 2014-02-06 19:37:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-02-06 19:37:48]

Retried try job too often on linux_chromeos for step(s) interactive_ui_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...

[Peter Lundblad, 2014-02-06 22:29:35]

The CQ bit was checked by plundblad@chromium.org

[commit-bot: I haz the power, 2014-02-06 22:31:45]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/plundblad@chromium.org/149233004/840001

[commit-bot: I haz the power, 2014-02-07 00:29:17]

Change committed as 249559