Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 1492293002: X87: [turbofan] Implemented the optional Float32RoundTiesEven operator. (Closed)

Created:
5 years ago by zhengxing.li
Modified:
5 years ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [turbofan] Implemented the optional Float32RoundTiesEven operator. port 57117b8339fe990867c4b8cc2c66f029a1a58bc3 (r32308) original commit message: The Float32RoundTiesEven operator rounds float32 numbers towards the nearest integer. If the distance to two integers is the same, then the result is the even integer. This is the default rounding mode of the ieee 754 floating point standard. I implemented the optional Float32RoundTiesEven operator on x64, ia32, arm, and arm64. BUG= Committed: https://crrev.com/0770fcba82f14c0c3dddbfee58a12a2da7fe2b0b Cr-Commit-Position: refs/heads/master@{#32595}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M src/compiler/x87/instruction-selector-x87.cc View 2 chunks +4 lines, -1 line 0 comments Download

Messages

Total messages: 17 (7 generated)
zhengxing.li
5 years ago (2015-12-03 08:37:53 UTC) #2
ahaas
lgtm
5 years ago (2015-12-03 15:45:14 UTC) #3
Weiliang
lgtm
5 years ago (2015-12-04 01:19:37 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1492293002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1492293002/1
5 years ago (2015-12-04 01:19:39 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: v8_win_rel_ng on tryserver.v8 (JOB_TIMED_OUT, http://build.chromium.org/p/tryserver.v8/builders/v8_win_rel_ng/builds/109)
5 years ago (2015-12-04 03:24:18 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1492293002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1492293002/1
5 years ago (2015-12-04 03:28:02 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: v8_win64_rel_ng on tryserver.v8 (JOB_TIMED_OUT, http://build.chromium.org/p/tryserver.v8/builders/v8_win64_rel_ng/builds/242)
5 years ago (2015-12-04 05:32:17 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1492293002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1492293002/1
5 years ago (2015-12-04 05:43:34 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-04 06:02:42 UTC) #15
commit-bot: I haz the power
5 years ago (2015-12-04 06:02:58 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0770fcba82f14c0c3dddbfee58a12a2da7fe2b0b
Cr-Commit-Position: refs/heads/master@{#32595}

Powered by Google App Engine
This is Rietveld 408576698