Issue 1492283004: ABANDONED CL: Introducing a compile-time-safe SavePackageId type.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1492283004: ABANDONED CL: Introducing a compile-time-safe SavePackageId type. (Closed)

Created:
5 years ago by Łukasz Anforowicz

Modified:
4 years, 9 months ago

Reviewers:

CC:
chromium-reviews, asanka, darin-cc_chromium.org, rginda+watch_chromium.org, loading-reviews_chromium.org, jam

Base URL:
https://chromium.googlesource.com/chromium/src.git@type-safe-id-base

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

ABANDONED CL: Introducing a compile-time-safe SavePackageId type. BUG=565545

Patch Set 1 #

Created: 5 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+44 lines, -32 lines)			Patch
M	content/browser/download/save_file_manager.h	View	7 chunks	+9 lines, -8 lines	0 comments	Download
M	content/browser/download/save_file_manager.cc	View	8 chunks	+10 lines, -9 lines	0 comments	Download
M	content/browser/download/save_file_resource_handler.h	View	3 chunks	+3 lines, -2 lines	0 comments	Download
M	content/browser/download/save_file_resource_handler.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	content/browser/download/save_package.h	View	3 chunks	+4 lines, -2 lines	0 comments	Download
M	content/browser/download/save_package.cc	View	4 chunks	+8 lines, -5 lines	0 comments	Download
M	content/browser/download/save_types.h	View	2 chunks	+6 lines, -1 line	0 comments	Download
M	content/browser/download/save_types.cc	View	2 chunks	+0 lines, -2 lines	0 comments	Download
M	content/browser/loader/resource_dispatcher_host_impl.h	View	2 chunks	+2 lines, -1 line	0 comments	Download
M	content/browser/loader/resource_dispatcher_host_impl.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Depends on Patchset:

Issue 1492413002 Patch 1

Messages

Total messages: 1 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Łukasz Anforowicz

4 years, 9 months ago (2016-03-02 19:26:47 UTC) #1

Description was changed from

==========
Introducing a compile-time-safe SavePackageId type.

BUG=565545
==========

to

==========
ABANDONED CL: Introducing a compile-time-safe SavePackageId type.

BUG=565545
==========

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages