chrome/browser/ui/webui/md_downloads/downloads_list_tracker_unittest.cc - Issue 1492273002: MD Downloads: limit the amount of downloads we send

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/md_downloads/downloads_list_tracker_unittest.cc

Issue 1492273002: MD Downloads: limit the amount of downloads we send (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@new-dl-data

Patch Set: self-review Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/webui/md_downloads/downloads_list_tracker.cc ('K') | « chrome/browser/ui/webui/md_downloads/downloads_list_tracker.cc ('k') | chrome/browser/ui/webui/md_downloads/md_downloads_dom_handler.cc » ('j') | chrome/browser/ui/webui/md_downloads/md_downloads_dom_handler.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/md_downloads/downloads_list_tracker_unittest.cc

diff --git a/chrome/browser/ui/webui/md_downloads/downloads_list_tracker_unittest.cc b/chrome/browser/ui/webui/md_downloads/downloads_list_tracker_unittest.cc

index fef30f308a013ef76248f8a8901d51f955a3e680..db46a928cab02188c261c594ef621e3465857eab 100644

--- a/chrome/browser/ui/webui/md_downloads/downloads_list_tracker_unittest.cc

+++ b/chrome/browser/ui/webui/md_downloads/downloads_list_tracker_unittest.cc

@@ -174,7 +174,7 @@ TEST_F(DownloadsListTrackerTest, StartCallsInsertItems) {

ASSERT_TRUE(tracker()->GetItemForTesting(0));

EXPECT_TRUE(web_ui()->call_data().empty());

- tracker()->Start();

+ tracker()->StartAndSendChunk();

ASSERT_FALSE(web_ui()->call_data().empty());

EXPECT_EQ("downloads.Manager.insertItems",

@@ -194,7 +194,7 @@ TEST_F(DownloadsListTrackerTest, EmptyGetAllItemsStillCallsInsertItems) {

ASSERT_FALSE(tracker()->GetItemForTesting(0));

ASSERT_TRUE(web_ui()->call_data().empty());

- tracker()->Start();

+ tracker()->StartAndSendChunk();

ASSERT_FALSE(web_ui()->call_data().empty());

EXPECT_EQ("downloads.Manager.insertItems",

@@ -205,7 +205,7 @@ TEST_F(DownloadsListTrackerTest, EmptyGetAllItemsStillCallsInsertItems) {

TEST_F(DownloadsListTrackerTest, OnDownloadCreatedCallsInsertItems) {

CreateTracker();

- tracker()->Start();

+ tracker()->StartAndSendChunk();

web_ui()->ClearTrackedCalls();

ASSERT_FALSE(tracker()->GetItemForTesting(0));

@@ -226,7 +226,7 @@ TEST_F(DownloadsListTrackerTest, OnDownloadRemovedCallsRemoveItem) {

DownloadItem* first_item = CreateNextItem();

CreateTracker();

- tracker()->Start();

+ tracker()->StartAndSendChunk();

web_ui()->ClearTrackedCalls();

EXPECT_TRUE(tracker()->GetItemForTesting(0));

@@ -244,7 +244,7 @@ TEST_F(DownloadsListTrackerTest, OnDownloadUpdatedCallsRemoveItem) {

DownloadItem* first_item = CreateNextItem();

CreateTracker();

- tracker()->Start();

+ tracker()->StartAndSendChunk();

web_ui()->ClearTrackedCalls();

EXPECT_TRUE(tracker()->GetItemForTesting(0));

@@ -266,7 +266,7 @@ TEST_F(DownloadsListTrackerTest, StartExcludesHiddenItems) {

DownloadItemModel(first_item).SetShouldShowInShelf(false);

CreateTracker();

- tracker()->Start();

+ tracker()->StartAndSendChunk();

ASSERT_FALSE(web_ui()->call_data().empty());