MD Downloads: limit the amount of downloads we send

chrome/browser/resources/md_downloads/action_service.js

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 cr.define('downloads', function() {
   /**
    * @param {string} chromeSendName
    * @return {function(string):void} A chrome.send() callback with curried name.
    */
   function chromeSendWithId(chromeSendName) {
@@ skipping 43 matching lines @@
     download: function(url) {
       var a = document.createElement('a');
       a.href = url;
       a.setAttribute('download', '');
       a.click();
     },
 
     /** @param {string} id ID of the download that the user started dragging. */
     drag: chromeSendWithId('drag'),
 
-    /** @private {boolean} */
-    isSearching_: false,
+    /** Loads more downloads with the current search terms. */
+    loadMore: function() {
+      chrome.send('getDownloads', this.searchTerms_);
+    },
 
     /**
      * @return {boolean} Whether the user is currently searching for downloads
      *     (i.e. has a non-empty search term).
      */
     isSearching: function() {
-      return this.isSearching_;
+      return this.searchTerms_.length > 0;
     },
 
     /** Opens the current local destination for downloads. */
     openDownloadsFolder: chrome.send.bind(chrome, 'openDownloadsFolder'),
 
     /**
      * @param {string} id ID of the download to run locally on the user's box.
      */
     openFile: chromeSendWithId('openFile'),
 
@@ skipping 11 matching lines @@
      *     warnings.
      */
     saveDangerous: chromeSendWithId('saveDangerous'),
 
     /** @param {string} searchText What to search for. */
     search: function(searchText) {
       if (this.searchText_ == searchText)
         return;
 
       this.searchText_ = searchText;
+      this.searchTerms_ = ActionService.splitTerms(this.searchText_);
+      this.loadMore();
+    },
 
-      var terms = ActionService.splitTerms(searchText);
-      this.isSearching_ = terms.length > 0;
+    /** @private {Array<string>} */
+    searchTerms_: [],
 
-      chrome.send('getDownloads', terms);
-    },
+    /** @private {string} */
+    searchText_: '',

[asanka, 2015/12/07 20:31:50]

Why do you keep this around?

[asanka, 2015/12/08 17:50:31]

To clarity, I meant: "Isn't this redundant since we also have searchTerms_?"

[Dan Beam, 2015/12/09 06:55:21]

Done.

 
     /**
      * Shows the local folder a finished download resides in.
      * @param {string} id ID of the download to show.
      */
     show: chromeSendWithId('show'),
 
     /** Undo download removal. */
     undo: chrome.send.bind(chrome, 'undo'),
   };
 
   cr.addSingletonGetter(ActionService);
 
   return {ActionService: ActionService};
 });