Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Issue 1492213002: X87: [stubs] A new approach to TF stubs. (Closed)

Created:
5 years ago by zhengxing.li
Modified:
5 years ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [stubs] A new approach to TF stubs. port 3e7e3ed726dd016dc6ae89803999a28fba2362c7 (r32508) original commit message: * Add a sibling interface to InterpreterAssembler called CodeStubAssembler which provides a wrapper around the RawMachineAssembler and is intented to make it easy to build efficient cross-platform code stubs. Much of the implementation of CodeStubAssembler is shamelessly stolen from the InterpreterAssembler, and the idea is to eventually merge the two interfaces somehow, probably moving the InterpreterAssembler interface over to use the CodeStubAssembler. Short-term, however, the two interfaces shall remain decoupled to increase our velocity developing the two systems in parallel. * Implement the StringLength stub in TurboFan with the new CodeStubAssembler. Replace and remove the old Hydrogen-stub version. * Remove a whole slew of machinery to support JavaScript-style code stub generation, since it ultimately proved unwieldy, brittle and baroque. This cleanup includes removing the shared code stub context, several example stubs and a tangle of build file changes. BUG= Committed: https://crrev.com/28a5baa01c41b25f105a9244c28f0ee2352ff42a Cr-Commit-Position: refs/heads/master@{#32538}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -21 lines) Patch
M src/x87/interface-descriptors-x87.cc View 1 chunk +0 lines, -21 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
zhengxing.li
5 years ago (2015-12-03 02:31:12 UTC) #2
Weiliang
lgtm
5 years ago (2015-12-03 04:17:44 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1492213002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1492213002/1
5 years ago (2015-12-03 04:18:00 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_arm64_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel/builds/12527)
5 years ago (2015-12-03 04:54:44 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1492213002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1492213002/1
5 years ago (2015-12-03 05:32:38 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-03 05:48:31 UTC) #10
commit-bot: I haz the power
5 years ago (2015-12-03 05:49:00 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/28a5baa01c41b25f105a9244c28f0ee2352ff42a
Cr-Commit-Position: refs/heads/master@{#32538}

Powered by Google App Engine
This is Rietveld 408576698