Issue 149213005: Dismiss <select> popup when the user taps the desktop background on CrOS

Issue 149213005: Dismiss <select> popup when the user taps the desktop background on CrOS (Closed)

Created:
6 years, 10 months ago by pkotwicz

Modified:
6 years, 10 months ago

Reviewers:
sadrul

CC:
chromium-reviews, joi+watch-content_chromium.org, yusukes+watch_chromium.org, yukishiino+watch_chromium.org, jam, penghuang+watch_chromium.org, sievers+watch_chromium.org, jbauman+watch_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, kalyank, piman+watch_chromium.org, danakj+watch_chromium.org, James Su, miu+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Dismiss <select> popup when the user taps the desktop background on CrOS BUG=336793 TEST=Manual, see bug Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=248593

Patch Set 1 #

Patch Set 2 : Added test #

Total comments: 1

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+41 lines, -6 lines)			Patch
M	content/browser/renderer_host/render_widget_host_view_aura.h	View	1	2 chunks	+4 lines, -2 lines	0 comments	Download
M	content/browser/renderer_host/render_widget_host_view_aura.cc	View	1	2 chunks	+9 lines, -3 lines	0 comments	Download
M	content/browser/renderer_host/render_widget_host_view_aura_unittest.cc	View	1	2 chunks	+28 lines, -1 line	1 comment	Download

Messages

Total messages: 9 (0 generated)

Expand Messages | Collapse Messages

sadrul

Do you mind adding a test for this (like the previous one you added for ...

6 years, 10 months ago (2014-01-29 06:30:38 UTC) #2

pkotwicz

Sadrul, can you please take another look? I have added a test.

6 years, 10 months ago (2014-02-03 15:52:24 UTC) #3

sadrul

LGTM. Thanks! https://codereview.chromium.org/149213005/diff/20001/content/browser/renderer_host/render_widget_host_view_aura_unittest.cc File content/browser/renderer_host/render_widget_host_view_aura_unittest.cc (right): https://codereview.chromium.org/149213005/diff/20001/content/browser/renderer_host/render_widget_host_view_aura_unittest.cc#newcode91 content/browser/renderer_host/render_widget_host_view_aura_unittest.cc:91: class TestWindowObserver : public aura::WindowObserver { Hm. ...

6 years, 10 months ago (2014-02-03 19:29:37 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/149213005/20001

6 years, 10 months ago (2014-02-03 19:34:11 UTC) #6

commit-bot: I haz the power

CQ bit was unchecked on CL. Ignoring.

6 years, 10 months ago (2014-02-03 22:24:32 UTC) #8

commit-bot: I haz the power

6 years, 10 months ago (2014-02-03 22:24:37 UTC) #9

Message was sent while issue was closed.

CQ bit was unchecked on CL. Ignoring.

Expand Messages | Collapse Messages