Remove some dependencies that cause content to be linked into the browser dll

Remove some dependencies that cause content to be linked into the browser dll

BUG=329384
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=247860

[jamesr, 2014-01-29 03:57:57]

https://codereview.chromium.org/149213004/diff/1/chrome/chrome_browser_ui.gypi
File chrome/chrome_browser_ui.gypi (left):

https://codereview.chromium.org/149213004/diff/1/chrome/chrome_browser_ui.gyp...
chrome/chrome_browser_ui.gypi:2859: '../ash/ash.gyp:ash_with_content',
i think this is backwards - chrome_browser_ui should be depending on the
ash_with_content target instead of ash (or possibly in addition to depending on
how the a_w_c target ends up)

ash_with_content should only be depending on content_browser (and possibly
content_common)

[jamesr, 2014-01-29 19:00:01]

lgtm

+ben who's been working on ash_with_content to double check that bit

[Ben Goodger (Google), 2014-01-29 19:03:18]

lgtm if it works.

https://codereview.chromium.org/149213004/diff/40001/ash/ash.gyp
File ash/ash.gyp (right):

https://codereview.chromium.org/149213004/diff/40001/ash/ash.gyp#newcode664
ash/ash.gyp:664: '../content/content.gyp:content_browser',
under what circumstances would you link only against content.gyp:content?

[jamesr, 2014-01-29 19:06:19]

On 2014/01/29 19:03:18, Ben Goodger (Google) wrote:
> lgtm if it works.
> 
> https://codereview.chromium.org/149213004/diff/40001/ash/ash.gyp
> File ash/ash.gyp (right):
> 
> https://codereview.chromium.org/149213004/diff/40001/ash/ash.gyp#newcode664
> ash/ash.gyp:664: '../content/content.gyp:content_browser',
> under what circumstances would you link only against content.gyp:content?

In the component build, content_browser (and the other content_...) are target
type 'none' and just forward to content, so the two are equivalent.

In the static build, you would link against content.gyp:content in test targets
that need to use all of content, like content_unittests.  It'd be the same as
linking against content_(browser|renderer|worker|child|common|...), but just not
as convenient.

We should possibly have some sort of thing to prevent production targets from
depending on content.gyp:content, as that's never right.

[commit-bot: I haz the power, 2014-01-29 19:18:19]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/scottmg@chromium.org/149213004/40001

[commit-bot: I haz the power, 2014-01-29 19:49:54]

Retried try job too often on ios_rel_device for step(s) compile
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=ios_rel_de...

[commit-bot: I haz the power, 2014-01-29 19:57:35]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/scottmg@chromium.org/149213004/50001

[commit-bot: I haz the power, 2014-01-29 22:35:38]

Retried try job too often on win_x64_rel for step(s) base_unittests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_x64_re...

[commit-bot: I haz the power, 2014-01-29 23:10:03]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/scottmg@chromium.org/149213004/90001

[commit-bot: I haz the power, 2014-01-30 03:04:34]

CQ bit was unchecked on CL. Ignoring.

[commit-bot: I haz the power, 2014-01-30 03:12:58]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/scottmg@chromium.org/149213004/90001

[commit-bot: I haz the power, 2014-01-30 06:54:33]

Change committed as 247860