Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Issue 149213002: android buildbot: Default to ninja's default target instead of All. (Closed)

Created:
6 years, 10 months ago by Nico
Modified:
6 years, 10 months ago
Reviewers:
Yaron
CC:
chromium-reviews, craigdh+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org, klundberg+watch_chromium.org, frankf+watch_chromium.org
Visibility:
Public.

Description

android buildbot: Default to ninja's default target instead of All. Before https://codereview.chromium.org/149103002/, chrome/android's default target was 'All', so no behavior change. After that lands, the default target is 'all', so the bots will build a few more targets (17 translation units more, at the moment). Together with the change linked above, this might enable the removal of |android_app_target|. BUG=none R=yfriedman@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=247607

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -6 lines) Patch
build/android/buildbot/bb_host_steps.py View 1 2 2 chunks +5 lines, -6 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Nico
6 years, 10 months ago (2014-01-28 23:38:33 UTC) #1
Yaron
On 2014/01/28 23:38:33, Nico wrote: lgtm
6 years, 10 months ago (2014-01-29 00:41:30 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/149213002/40001
6 years, 10 months ago (2014-01-29 01:41:34 UTC) #3
Nico
Committed patchset #3 manually as r247607 (tree was closed).
6 years, 10 months ago (2014-01-29 03:00:35 UTC) #4
commit-bot: I haz the power
6 years, 10 months ago (2014-01-29 03:01:28 UTC) #5
Message was sent while issue was closed.
CQ bit was unchecked on CL. Ignoring.

Powered by Google App Engine
This is Rietveld 408576698