Preserve information about dots in numbers across parser rewriting.

Preserve information about dots in numbers across parser rewriting.

Fix several operations in the parser that rewrite constant expressions
to preserve knowledge regarding whether a value originally contained a ".".
This information is required to accurately validate Asm.js typing.

Making the assumption that if either side of a binary operation contains
a dot, that the rewritten expression should be treated as a double for
Asm.js purposes. This is a slight deviation from the spec (which
would forbid mix type operations).

BUG= https://code.google.com/p/v8/issues/detail?id=4203
TEST=test-asm-validator, test-parsing
R=titzer@chromium.org,marja@chromium.org,aseemgarg@chromium.org
LOG=N

Committed: https://crrev.com/1e4681c33fd4ea3d5a872033b2c4626ad150a533
Cr-Commit-Position: refs/heads/master@{#32581}

[bradn, 2015-12-02 20:43:44]

Description was changed from

==========
Preserve information about dots in numbers across parser rewriting.

Fix several operations in the parser that rewrite constant expressions
to preserve knowledge regarding whether a value originally contained a ".".
This information is required to accurately validate Asm.js typing.

Making the assumption that if either side of a binary operation contains
a dot, that the rewritten expression should be treated as a double for
Asm.js purposes. This is a slight deviation from the spec (which
would forbid mix type operations).

BUG= https://code.google.com/p/v8/issues/detail?id=4203
TEST=test-asm-validator
R=titzer@chromium.org,marja@chromium.org,aseemgarg@chromium.org
LOG=N
==========

to

==========
Preserve information about dots in numbers across parser rewriting.

Fix several operations in the parser that rewrite constant expressions
to preserve knowledge regarding whether a value originally contained a ".".
This information is required to accurately validate Asm.js typing.

Making the assumption that if either side of a binary operation contains
a dot, that the rewritten expression should be treated as a double for
Asm.js purposes. This is a slight deviation from the spec (which
would forbid mix type operations).

BUG= https://code.google.com/p/v8/issues/detail?id=4203
TEST=test-asm-validator, test-parsing
R=titzer@chromium.org,marja@chromium.org,aseemgarg@chromium.org
LOG=N
==========

[bradn, 2015-12-02 20:45:08]

PTAL

I'm a little concerned we might want to simply turn off the rewrites for asm.js,
long term to be more correct. But this is ok for now.

[aseemgarg, 2015-12-02 21:15:05]

lgtm

looks good to me. Though as you mention, might be better, longterm, to keep +x
rather than convert to x*1.0 as technically int*double is an invalid operation.
Same for ~~x.

[bradn, 2015-12-02 22:22:50]

The CQ bit was checked by bradnelson@google.com

[commit-bot: I haz the power, 2015-12-02 22:22:55]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1492123002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1492123002/1

[commit-bot: I haz the power, 2015-12-02 22:22:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-02 22:22:56]

No L-G-T-M from a valid reviewer yet. Only full committers are accepted.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[bradn, 2015-12-03 17:13:26]

ping

[titzer, 2015-12-03 17:50:06]

On 2015/12/03 17:13:26, bradn wrote:
> ping

lgtm

[bradn, 2015-12-03 17:55:09]

The CQ bit was checked by bradnelson@google.com

[commit-bot: I haz the power, 2015-12-03 17:55:12]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1492123002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1492123002/1

[commit-bot: I haz the power, 2015-12-03 18:14:16]

Description was changed from

==========
Preserve information about dots in numbers across parser rewriting.

Fix several operations in the parser that rewrite constant expressions
to preserve knowledge regarding whether a value originally contained a ".".
This information is required to accurately validate Asm.js typing.

Making the assumption that if either side of a binary operation contains
a dot, that the rewritten expression should be treated as a double for
Asm.js purposes. This is a slight deviation from the spec (which
would forbid mix type operations).

BUG= https://code.google.com/p/v8/issues/detail?id=4203
TEST=test-asm-validator, test-parsing
R=titzer@chromium.org,marja@chromium.org,aseemgarg@chromium.org
LOG=N
==========

to

==========
Preserve information about dots in numbers across parser rewriting.

Fix several operations in the parser that rewrite constant expressions
to preserve knowledge regarding whether a value originally contained a ".".
This information is required to accurately validate Asm.js typing.

Making the assumption that if either side of a binary operation contains
a dot, that the rewritten expression should be treated as a double for
Asm.js purposes. This is a slight deviation from the spec (which
would forbid mix type operations).

BUG= https://code.google.com/p/v8/issues/detail?id=4203
TEST=test-asm-validator, test-parsing
R=titzer@chromium.org,marja@chromium.org,aseemgarg@chromium.org
LOG=N
==========

[commit-bot: I haz the power, 2015-12-03 18:14:17]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-12-03 18:14:49]

Description was changed from

==========
Preserve information about dots in numbers across parser rewriting.

Fix several operations in the parser that rewrite constant expressions
to preserve knowledge regarding whether a value originally contained a ".".
This information is required to accurately validate Asm.js typing.

Making the assumption that if either side of a binary operation contains
a dot, that the rewritten expression should be treated as a double for
Asm.js purposes. This is a slight deviation from the spec (which
would forbid mix type operations).

BUG= https://code.google.com/p/v8/issues/detail?id=4203
TEST=test-asm-validator, test-parsing
R=titzer@chromium.org,marja@chromium.org,aseemgarg@chromium.org
LOG=N
==========

to

==========
Preserve information about dots in numbers across parser rewriting.

Fix several operations in the parser that rewrite constant expressions
to preserve knowledge regarding whether a value originally contained a ".".
This information is required to accurately validate Asm.js typing.

Making the assumption that if either side of a binary operation contains
a dot, that the rewritten expression should be treated as a double for
Asm.js purposes. This is a slight deviation from the spec (which
would forbid mix type operations).

BUG= https://code.google.com/p/v8/issues/detail?id=4203
TEST=test-asm-validator, test-parsing
R=titzer@chromium.org,marja@chromium.org,aseemgarg@chromium.org
LOG=N

Committed: https://crrev.com/1e4681c33fd4ea3d5a872033b2c4626ad150a533
Cr-Commit-Position: refs/heads/master@{#32581}
==========

[commit-bot: I haz the power, 2015-12-03 18:14:50]

Patchset 1 (id:??) landed as
https://crrev.com/1e4681c33fd4ea3d5a872033b2c4626ad150a533
Cr-Commit-Position: refs/heads/master@{#32581}