Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Issue 14921005: Remove MSVC7_OR_LOWER and MSVC9_OR_LOWER. (Closed)

Created:
7 years, 7 months ago by Nico
Modified:
7 years, 7 months ago
Reviewers:
pdr., abarth-chromium
CC:
blink-reviews, loislo+blink_chromium.org, eae+blinkwatch, yurys+blink_chromium.org, abarth-chromium, adamk+blink_chromium.org, jeez
Visibility:
Public.

Description

Remove MSVC7_OR_LOWER and MSVC9_OR_LOWER. We only support building with MSVC2010. (See "[chromium-dev] ANN: VS2008 deprecation happening now" from Dec 2012.) BUG=none R=abarth@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=150395

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : .. #

Patch Set 4 : ... #

Patch Set 5 : ............ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -90 lines) Patch
M Source/core/platform/chromium/TraceEvent.h View 4 chunks +0 lines, -16 lines 0 comments Download
M Source/wtf/Assertions.h View 1 2 3 4 10 chunks +6 lines, -45 lines 0 comments Download
M Source/wtf/Atomics.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/wtf/Compiler.h View 1 chunk +0 lines, -7 lines 0 comments Download
M Source/wtf/DateMath.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/wtf/MathExtras.h View 1 chunk +0 lines, -4 lines 0 comments Download
M Source/wtf/RefCountedLeakCounter.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/wtf/StaticConstructors.h View 1 chunk +0 lines, -10 lines 0 comments Download
M Source/wtf/os-win32/inttypes.h View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Nico
7 years, 7 months ago (2013-05-15 02:03:45 UTC) #1
Nico
7 years, 7 months ago (2013-05-15 02:25:53 UTC) #2
abarth-chromium
lgtm
7 years, 7 months ago (2013-05-15 02:41:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/14921005/12001
7 years, 7 months ago (2013-05-15 02:44:52 UTC) #4
Nico
7 years, 7 months ago (2013-05-15 05:39:28 UTC) #5
Message was sent while issue was closed.
Committed patchset #5 manually as r150395 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698