Issue 14921004: Revert "Clear highlight when the highlighted node gets removed from the document"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14921004: Revert "Clear highlight when the highlighted node gets removed from the document" (Closed)

Created:
7 years, 7 months ago by dglazkov

Modified:
7 years, 7 months ago

Reviewers:
trchen

CC:
blink-reviews

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Revert "Clear highlight when the highlighted node gets removed from the document" This reverts http://src.chromium.org/viewvc/blink?view=revision&revision=149814, because the test that was landed with it is failing immediately after landing. TBR=trchen@chromium.org BUG=232926 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=149824

Patch Set 1 #

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+0 lines, -80 lines)			Patch
M	Source/WebKit/chromium/src/LinkHighlight.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	Source/WebKit/chromium/src/LinkHighlight.cpp	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	Source/WebKit/chromium/tests/LinkHighlightTest.cpp	View	3 chunks	+0 lines, -75 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

trchen

On 2013/05/07 00:20:23, Dimitri Glazkov wrote: > Committed patchset #1 manually as r149824. Which bot ...

7 years, 7 months ago (2013-05-07 00:44:09 UTC) #3

dglazkov

7 years, 7 months ago (2013-05-07 00:54:47 UTC) #4

Message was sent while issue was closed.

http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.6%20%28db...
http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win7%20%28dbg%2...
and possibly others.

The build bot only mails when there's a tree-closing failure, which is a compile
step at the moment.

Expand Messages | Collapse Messages