third_party/WebKit/Source/core/dom/DOMURL.cpp - Issue 1492093002: Drop [LegacyInterfaceTypeChecking] for URL.createObjectURL(blob)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/DOMURL.cpp

Issue 1492093002: Drop [LegacyInterfaceTypeChecking] for URL.createObjectURL(blob) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: update tests Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/imported/web-platform-tests/FileAPI/url/url_xmlhttprequest-expected.txt ('k') | third_party/WebKit/Source/core/dom/URL.idl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/dom/DOMURL.cpp

diff --git a/third_party/WebKit/Source/core/dom/DOMURL.cpp b/third_party/WebKit/Source/core/dom/DOMURL.cpp

index 61c56bf014258baa4adedcd199bdca7ff9cd86ad..89fc742aa2ea35b1567f3ef04e9822a023fb7c32 100644

--- a/third_party/WebKit/Source/core/dom/DOMURL.cpp

+++ b/third_party/WebKit/Source/core/dom/DOMURL.cpp

@@ -64,7 +64,8 @@ void DOMURL::setInput(const String& value)

String DOMURL::createObjectURL(ExecutionContext* executionContext, Blob* blob, ExceptionState& exceptionState)

{

- if (!executionContext || !blob)

+ ASSERT(blob);

+ if (!executionContext)

return String();

if (blob->hasBeenClosed()) {

exceptionState.throwDOMException(InvalidStateError, String(blob->isFile() ? "File" : "Blob") + " has been closed.");