extensions/common/constants.h - Issue 1492073003: Handle more scale factors for extension Browser Action icons

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/common/constants.h

Issue 1492073003: Handle more scale factors for extension Browser Action icons (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: test catches real bug! Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/common/extensions/api/extension_action/browser_action_manifest_unittest.cc ('k') | extensions/common/constants.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/common/constants.h

diff --git a/extensions/common/constants.h b/extensions/common/constants.h

index 7af8701b79d27ab198ea18cca7cf50aef752eb9c..802289634ba6c080ca728c2603b4ad1cf091b80e 100644

--- a/extensions/common/constants.h

+++ b/extensions/common/constants.h

@@ -194,20 +194,6 @@ enum ExtensionIcons {

extern const int kExtensionIconSizes[];

extern const size_t kNumExtensionIconSizes;

-struct IconRepresentationInfo {

- // Size in pixels.

- const int size;

- // Size as a string that will be used to retrieve representation value from

- // ExtensionAction SetIcon function arguments.

- const char* const size_string;

- // Scale factor for which the representation should be used.

- const ui::ScaleFactor scale;

-};

-// The icon representations for extension actions.

-extern const IconRepresentationInfo kExtensionActionIconSizes[];

-const size_t kNumExtensionActionIconSizes = 2u;

// The extension id of the PDF extension.

extern const char kPdfExtensionId[];